Enable test suite of libarrow#1058
Merged
h-vetinari merged 11 commits intoconda-forge:mainfrom Nov 25, 2024
Merged
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
26074b3 to
afb81ea
Compare
kou
added a commit
to apache/arrow
that referenced
this pull request
Nov 15, 2024
) ### Rationale for this change Enable tests for libarrow in conda-forge: #35587 ### What changes are included in this PR? old glibc does not actually support timezones like `-0117` (used in `StrptimeZoneOffset` test). The exact lower bound for glibc is hard for me to determine; I know that it passes with 2.28 and that it fails with 2.17. Anything in between is an open question. I went with the conservative option here. ### Are these changes tested? Tested in conda-forge/arrow-cpp-feedstock#1058 ### Are there any user-facing changes? * GitHub Issue: #43808 Lead-authored-by: H. Vetinari <h.vetinari@gmx.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
except those depending on timing, following upstream, see https://github.com/apache/arrow/blob/apache-arrow-12.0.0/ci/appveyor-cpp-build.bat#L63-L68
also requires git submodule for parquet test data
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12000178104. Examine the logs at this URL for more detail. |
cannot run test suite without an actual GPU
libarrowlibarrow
Member
Author
|
Alrighty, after over 2 years of working towards this, we now have the C++ tests running for |
h-vetinari
added a commit
that referenced
this pull request
Nov 25, 2024
Enable test suite of `libarrow`
This was referenced Dec 9, 2024
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/arrow
that referenced
this pull request
Jul 7, 2025
…621) ### Rationale for this change Enable tests for libarrow in conda-forge: apache/arrow#35587 ### What changes are included in this PR? old glibc does not actually support timezones like `-0117` (used in `StrptimeZoneOffset` test). The exact lower bound for glibc is hard for me to determine; I know that it passes with 2.28 and that it fails with 2.17. Anything in between is an open question. I went with the conservative option here. ### Are these changes tested? Tested in conda-forge/arrow-cpp-feedstock#1058 ### Are there any user-facing changes? * GitHub Issue: #43808 Lead-authored-by: H. Vetinari <h.vetinari@gmx.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #875, we're now running with the test suite for
pyarrow. While working on #1048, I wanted to ensure that also the library portion works as intended, so thought about switching on the test suite forlibarrow.After some initial attempts it looks like this is failing, hence will need some iteration together with upstream.