Use local date time format in CSV#8398
Merged
aembler merged 5 commits intoconcretecms:developfrom Feb 14, 2020
Merged
Conversation
ATOM format is hard to use for normal user in Japan.
Contributor
|
What about making it configurable? |
Contributor
Author
|
@mlocati like this? |
ref: concretecms#8398 To configurable datetime format
Contributor
Yes! 👍 |
Contributor
Author
|
@mlocati But, I think that datetime format is set by locale setting at almost case when use in non-English. |
KorvinSzanto
reviewed
Feb 7, 2020
5.6対応しないといかんのか…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATOM format is hard to use for normal user in Japan.
I read the guidelines for contributing linked above
PHP-only files follow our coding style; in order to do that use php-cs-fixer - http://cs.sensiolabs.org/ - as follows:
php-cs-fixer fix --config=<webroot>/.php_cs.dist <filename>