6755: next_previous block skips pages#6756
Merged
aembler merged 3 commits intoconcretecms:developfrom Jun 14, 2018
Merged
Conversation
Equivalent date page get skipped as well as pages before/after an inaccessible page.
Member
|
I think we should review this – not sure about some of the constructs used in this code, although I understand the problem it's solving. |
Contributor
|
The only relevant changes are small changes in the queries. BTW, I'd optimize the code a bit, checking that pages are loaded without errors and reducing duplicated code: see gfischershaw#1 If @gfischershaw accepts gfischershaw#1 it will be added to #6756 |
Simplify code and check valid pages
mlocati
approved these changes
Jun 12, 2018
Contributor
|
LGTM, it does fixes the issue. Thanks @gfischershaw! |
Member
|
Thanks both of you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equivalent date page get skipped as well as pages before/after an inaccessible page.