Merged
Conversation
kevincheng96
commented
Apr 13, 2023
1208f83 to
d9c2f85
Compare
jflatow
approved these changes
Apr 14, 2023
Contributor
jflatow
left a comment
There was a problem hiding this comment.
Not a fan of additional surface area for contracts, but makes sense. Big fan of the price feeds directory 🧼
7d63533 to
29c36d7
Compare
scott-silver
approved these changes
May 25, 2023
4dc6ca3 to
554d573
Compare
554d573 to
bde60e1
Compare
Contributor
Author
|
Final audit report from OZ |
kevincheng96
added a commit
that referenced
this pull request
Aug 3, 2023
This generalizes the logic used in the recently audited [`WBTCPriceFeed`](#737) to create a `MultiplicativePriceFeed` that derives its price from multiplying the prices from two other price feeds together. This is a flexible wrapper price feed that can be used to generate prices for any asset that does not have a price feed that fits Comet's expected price denomination. e.g. if we wanted to add `cbETH` to `cUSDCv3`, there is no Chainlink price feed for `cbETH / USD`, so we would need to multiply the `cbETH / ETH` and `ETH / USD` price feeds together to get `cbETH / USD`
crypto-knightjk98
added a commit
to crypto-knightjk98/comet
that referenced
this pull request
Sep 27, 2025
This generalizes the logic used in the recently audited [`WBTCPriceFeed`](compound-finance/comet#737) to create a `MultiplicativePriceFeed` that derives its price from multiplying the prices from two other price feeds together. This is a flexible wrapper price feed that can be used to generate prices for any asset that does not have a price feed that fits Comet's expected price denomination. e.g. if we wanted to add `cbETH` to `cUSDCv3`, there is no Chainlink price feed for `cbETH / USD`, so we would need to multiply the `cbETH / ETH` and `ETH / USD` price feeds together to get `cbETH / USD`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a custom price feed for WBTC / USD by reading from both the WBTC / BTC and BTC / USD price feeds. This will allow the cUSDCv3 market to get a more accurate price for WBTC.
We also organize the contracts repo by moving all the custom price feed contracts into a separate
pricefeedssubdirectory.