Skip to content

Arbitrum deploy#712

Merged
kevincheng96 merged 28 commits intomainfrom
silver/arbitrum
May 15, 2023
Merged

Arbitrum deploy#712
kevincheng96 merged 28 commits intomainfrom
silver/arbitrum

Conversation

@scott-silver
Copy link
Copy Markdown
Contributor

@scott-silver scott-silver commented Mar 9, 2023

Work-in-progress Arbitrum deploy.

Initial PR sets up the ArbitrumBridgeReceiver contract, a few governance scenarios, and a message-passing relayer (no token bridging).

Some todos:

@scott-silver scott-silver changed the title [DRAFT] Arbitrum deploy Arbitrum deploy Mar 17, 2023
@scott-silver scott-silver marked this pull request as ready for review March 17, 2023 21:45
@scott-silver scott-silver force-pushed the silver/arbitrum branch 2 times, most recently from a86ac83 to 3b36dec Compare March 21, 2023 21:13
@jflatow jflatow added deployment This PR contains a new deployment audited These changes have been audited labels Apr 11, 2023
Copy link
Copy Markdown
Contributor

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this, almost at the finish line 💪

@kevincheng96 kevincheng96 force-pushed the silver/arbitrum branch 2 times, most recently from 75fc7ad to c286da6 Compare April 24, 2023 18:54
@kevincheng96
Copy link
Copy Markdown
Contributor

Contracts have been deployed and verified on testnet in this job: https://github.com/compound-finance/comet/actions/runs/4790017433/jobs/8518589699

scott-silver and others added 6 commits May 4, 2023 11:09
* update github actions

* add configuration file

* deploy script

* add inbox to roots

* update hardhat config

* update etherscan.ts

* template string in Spider trace fn

* Arbitrum whale

* MAINNET_TIMELOCK instead of mainnetTimelock.address

* add inbox to mainnet/usdc relations

* missing whale error

* add LINK, LINK whale

add Arbitrum SDK; bump hardhat-etherscan version; ARBISCAN_KEY; add l1GatewayRouter to roots; update getCompWhales
* Initial implementation of CometRewards with multiplier

* Simply implementation a bit

* Refactor slightly for more readability

* Update unit tests

* Implement setRewardsClaimed (#703)

This PR introduces a `setRewardsClaimed` function that gives the admin the ability to set rewards claimed for any user. This gives us the ability to initialize a new reward distribution that doesn't necessarily have to retroactively reward all past usage of Comet. 

We would have to compute off-chain the amount that each user would be able to claim at a specific block number `x` and write it on-chain via the `setRewardsClaimed` function. This allows us to essentially set the start time of the rewards accrual to be after that specific block number `x`.

* Add scenarios for testing reward multipliers

* Re-implement multiplier logic by storing multiplier in RewardConfig

* Add a unit test to sanity check zeroing out retroactive rewards for users
@kevincheng96
Copy link
Copy Markdown
Contributor

Arbitrum mainnet contracts have been deployed in this job: https://github.com/compound-finance/comet/actions/runs/4887412993/jobs/8723953331

scott-silver and others added 3 commits May 10, 2023 16:27
* Arbitrum proposals

* update Arbitrum aliases in proposals

* update asset supply caps

* spider in verify()

* add prices to BulkerScenario

* restore original asset variables; update supply cap expectations; enable diffState test for Arbitrum-Goerli

* Add arb to enact-migration.yaml

* Modified migration from GitHub Actions

* Finalize arb gas estimation

* update proposal description

* update diffState test

* add action to set v2 COMP speeds for USDT to 0; update Arbitrum baseSupplySpeed

* Skip calling verify on migrations that are already enacted

* Update COMP amount to bridge and hardcoded gas price; modify proposal text to be more specific about shifting COMP distributions from USDT v2 to Arbitrum

* Change skip to skipVerify

* Add COMP whale for arbitrum-goerli

* Modified migration from GitHub Actions

---------

Co-authored-by: kevincheng96 <kevincheng96@hotmail.com>
Co-authored-by: GitHub Actions Bot <>
Copy link
Copy Markdown
Contributor

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge now that the Arbitrum market is live (proposal 160).

@kevincheng96 kevincheng96 merged commit d7b414d into main May 15, 2023
@kevincheng96 kevincheng96 deleted the silver/arbitrum branch May 15, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audited These changes have been audited deployment This PR contains a new deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants