Skip to content

Proposal to enable cWETHv3 market on Goerli#647

Merged
kevincheng96 merged 4 commits intokevin/goerli-weth-deployfrom
kevin/enable-goerli-weth
Jan 5, 2023
Merged

Proposal to enable cWETHv3 market on Goerli#647
kevincheng96 merged 4 commits intokevin/goerli-weth-deployfrom
kevin/enable-goerli-weth

Conversation

@kevincheng96
Copy link
Copy Markdown
Contributor

@kevincheng96 kevincheng96 commented Jan 4, 2023

@kevincheng96 kevincheng96 changed the base branch from main to kevin/deploy-weth-goerli January 4, 2023 19:33
@kevincheng96 kevincheng96 changed the base branch from kevin/deploy-weth-goerli to kevin/goerli-weth-deploy January 4, 2023 19:33
@kevincheng96 kevincheng96 marked this pull request as ready for review January 4, 2023 20:35
"tracking": {
"indexScale": "1e15",
"baseSupplySpeed": "0e15",
"baseSupplySpeed": "447916666666e0",
Copy link
Copy Markdown
Contributor Author

@kevincheng96 kevincheng96 Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could modify the stringToBigInt function to accept non-scientific notation numbers as well. But this is a quick workaround.

@kevincheng96 kevincheng96 force-pushed the kevin/goerli-weth-deploy branch from df1eb4b to 887a1cd Compare January 4, 2023 23:04
@kevincheng96 kevincheng96 force-pushed the kevin/enable-goerli-weth branch from 3580ac3 to 7ae47b2 Compare January 4, 2023 23:11
@jflatow jflatow added the proposal This PR contains a governance proposal label Jan 5, 2023
@kevincheng96 kevincheng96 force-pushed the kevin/enable-goerli-weth branch from 7ae47b2 to 8773058 Compare January 5, 2023 19:26
Copy link
Copy Markdown
Contributor

@jflatow jflatow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼

@kevincheng96
Copy link
Copy Markdown
Contributor Author

@kevincheng96
Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proposal This PR contains a governance proposal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants