Improve CompilingMatcher by caching the result too#131
Merged
Seldaek merged 1 commit intocomposer:mainfrom Mar 14, 2022
Merged
Conversation
Member
|
Thanks |
Seldaek
added a commit
that referenced
this pull request
Mar 15, 2022
This was referenced Mar 15, 2022
This was referenced Apr 22, 2022
This was referenced May 2, 2022
This was referenced May 16, 2022
Closed
This was referenced May 26, 2022
This was referenced Jun 6, 2022
This was referenced Jun 14, 2022
This was referenced Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the function calls in the
PoolOptimizerby a few hundred thousand and again, we can save a second or two or even more depending on the complexity of the dependencies ;-)