Implemented php version check in autoload.php#8546
Conversation
df3121f to
ca2531d
Compare
|
Should we do this just for PHP or also all extensions? |
|
From my experience, most devs tend to only require |
|
@Toflar Well I'd compile the check into a single file anyway, no need for multiple files? |
|
But yeah for most extensions I guess we just check presence, then again any unbounded constraint can just be skipped for code generation anyway? |
|
The code generation currently just generates |
|
Thank you for this useful feature. It is a breaking change that should be noted to |
|
Thanks! @GromNaN that's right it should be mentioned, I'll update UPGRADE/CHANGELOG sometime this week again with latest changes. |
|
I didn't analyzed the code in detail, but I'm pretty sure this change does not takes care of the provided PHP-extensions, as is in the case of using alcaeus/mongo-php-adapter We had a production issue on deploy, because we perform an autoloader optimization downloading the composer.phar from https://getcomposer.org/composer.phar that currently returns the 2.x dev branch (issue is already open #8831 ) |
|
@curzio-della-santa that's absolutely correct, I am coincidentally just working on handling this :) Will commit a fix soon. |
… are provided by packages, refs #8546
Integrates composer/semver#75 in Composer.
Successfully tested on one of my projects. Ran
composer updatewith PHP 7.4.1 and then tried to run the app with 7.3.13 which now doesn't work anymore (in my case, because the version ofocramius/proxy-managerin mycomposer.lockrequires7.4.*) :)