scope isolation for user includes#2667
Conversation
src/bootstrap.php
Outdated
There was a problem hiding this comment.
no need to use includeIfExists here. It will always exist as it is in the repo.
and no need to use ../src/ as __DIR__ is already the src folder
|
Build fails because of function redefinition. |
|
Fixed |
|
@stof You see any issues with this? I don't really see what the big deal with being able to access $this theoretically is, but this is fine by me too. |
|
It looks fine to me. |
|
Yeah I think that we can live with, so merging this. |
scope isolation for user includes
There was a problem hiding this comment.
Err now that I think about it, i forgot to comment on this, why doesn't this function just have a proper parameter?
There was a problem hiding this comment.
Guess I can answer that myself, to keep the scope empty :)
Prevents access to $this/self from included files.