Skip to content

version-patch#489

Merged
ndeloof merged 1 commit intocompose-spec:masterfrom
aevesdocker:version-patch
Apr 22, 2024
Merged

version-patch#489
ndeloof merged 1 commit intocompose-spec:masterfrom
aevesdocker:version-patch

Conversation

@aevesdocker
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Makes it clear that users will receive a warning message that 'Version' is obsolete.

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: aevesdocker <allie.sadler@docker.com>
@ndeloof ndeloof merged commit 6d19079 into compose-spec:master Apr 22, 2024
overclokk added a commit to ItalyStrap/theme-json-generator that referenced this pull request May 30, 2024
yahonda added a commit to yahonda/buildkite-config that referenced this pull request Jun 4, 2024
This commit removes the obsolete `version` from docker-compose.yml

- Steps to reproduce
```
git clone https://github.com/rails/rails
cd rails
git clone https://github.com/rails/buildkite-config .buildkite/
RUBY_IMAGE=ruby:3.3 docker compose -f .buildkite/docker-compose.yml build base
```

- Without this commit, it shows this warning.
```
WARN[0000] /home/yahonda/rails/.buildkite/docker-compose.yml: `version` is obsolete
```

Refer to compose-spec/compose-spec#489
ledsun added a commit to pubannotation/pubdictionaries that referenced this pull request Jul 19, 2024
The version field is obsoleted in compose spec 2.0
compose-spec/compose-spec#489
lx-nihei pushed a commit to lx-nihei/pubdictionaries that referenced this pull request Sep 4, 2024
The version field is obsoleted in compose spec 2.0
compose-spec/compose-spec#489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants