Skip to content

introduce ability to define secret by environment variable#257

Merged
ndeloof merged 1 commit intocompose-spec:masterfrom
ndeloof:env_secret
May 30, 2022
Merged

introduce ability to define secret by environment variable#257
ndeloof merged 1 commit intocompose-spec:masterfrom
ndeloof:env_secret

Conversation

@ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented May 18, 2022

What this PR does / why we need it:
introduce ability to define secret by environment variable

Which issue(s) this PR fixes:
Fixes #251

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@EricHripko EricHripko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ✅ Excited about this addition 🎉

@ndeloof ndeloof merged commit 5260c1b into compose-spec:master May 30, 2022
@ndeloof ndeloof deleted the env_secret branch May 30, 2022 09:11
milas added a commit to milas/docker.github.io that referenced this pull request Sep 1, 2022
* tmpfs.mode: compose-spec/compose-spec#252
* build.tags: compose-spec/compose-spec#255
* env var secrets: compose-spec/compose-spec#257
* build.platforms: compose-spec/compose-spec#267

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to define secrets from environment variables

4 participants