Skip to content

Conversation

@ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented May 14, 2025

github.com/xeipuuv/gojsonschema is inactive (last commit is 5 years old)
switch to github.com/xeipuuv/gojsonschema with best effort to preserve error messages

closes #749

tested with compose by docker/compose#12831

@ndeloof ndeloof requested a review from glours May 14, 2025 11:10
@ndeloof ndeloof force-pushed the jsonschema branch 3 times, most recently from 9eea19e to d866362 Compare May 14, 2025 12:16
ndeloof added a commit to ndeloof/compose that referenced this pull request May 14, 2025
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours enabled auto-merge (rebase) May 27, 2025 08:59
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@glours glours merged commit 8792426 into compose-spec:main Jun 3, 2025
8 checks passed
@ndeloof ndeloof deleted the jsonschema branch June 3, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: consider switching JSON-schema dependency to github.com/santhosh-tekuri/jsonschema

2 participants