Revert usage of "-" as separator for resource names#297
Merged
ulyssessouza merged 1 commit intocompose-spec:masterfrom Aug 1, 2022
Merged
Revert usage of "-" as separator for resource names#297ulyssessouza merged 1 commit intocompose-spec:masterfrom
ulyssessouza merged 1 commit intocompose-spec:masterfrom
Conversation
ed7dcc9 to
2c4d6cf
Compare
ndeloof
approved these changes
Aug 1, 2022
Collaborator
ndeloof
left a comment
There was a problem hiding this comment.
+1
while mix of dash and underscore can create some confusion, the benefit is poor regarding the backward compatibility impact
|
Also pinging here for more visibility. I am having some trouble with the updated compose version 2.9.0 where this fix should be applied. Essentially the separator still seems to be see more context and a repro case here docker/compose#9700 (comment) E: Turns out that I was just confused. The revertion was done only for related resources like networks, volumes, secrets and config. The container names will be using |
ThorgateDeveloper
pushed a commit
to thorgate/django-project-template
that referenced
this pull request
Aug 5, 2022
Docker changed the behaviour of the container naming to use `-`. Originally we believed that this change was reverted in 2.9.0 as it caused a breaking change. But it turns out instead they reverted it only for related resources such as networks, volumes, secrets and config. This means that going forward the container names use dashes (`-`). Note: Also updated the poetry wrapper image name to match this new convention. Refs: - https://docs.docker.com/compose/release-notes/#290 - docker/compose#9700 - docker/compose#9700 (comment) - compose-spec/compose-go#297 - Internal ref: https://thorgate.slack.com/archives/C02AMG235/p1659433239011469 Additional changes in the PR: - Update poetry installation command - ref: https://python-poetry.org/docs/master/#installing-with-the-official-installer - Remove pypi docker compose in ci image (docker-compose now comes from inside docker image anyway)
ThorgateDeveloper
pushed a commit
to thorgate/django-project-template
that referenced
this pull request
Aug 5, 2022
Docker changed the behaviour of the container naming to use `-`. Originally we believed that this change was reverted in 2.9.0 as it caused a breaking change. But it turns out instead they reverted it only for related resources such as networks, volumes, secrets and config. This means that going forward the container names use dashes (`-`). Note: Also updated the poetry wrapper image name to match this new convention. Refs: - https://docs.docker.com/compose/release-notes/#290 - docker/compose#9700 - docker/compose#9700 (comment) - compose-spec/compose-go#297 - Internal ref: https://thorgate.slack.com/archives/C02AMG235/p1659433239011469 Additional changes in the PR: - Update poetry installation command - ref: https://python-poetry.org/docs/master/#installing-with-the-official-installer - Remove pypi docker compose in ci image (docker-compose now comes from inside docker image anyway)
IncrePrior
added a commit
to IncrePrior/django-project-template
that referenced
this pull request
Nov 12, 2023
Docker changed the behaviour of the container naming to use `-`. Originally we believed that this change was reverted in 2.9.0 as it caused a breaking change. But it turns out instead they reverted it only for related resources such as networks, volumes, secrets and config. This means that going forward the container names use dashes (`-`). Note: Also updated the poetry wrapper image name to match this new convention. Refs: - https://docs.docker.com/compose/release-notes/#290 - docker/compose#9700 - docker/compose#9700 (comment) - compose-spec/compose-go#297 - Internal ref: https://thorgate.slack.com/archives/C02AMG235/p1659433239011469 Additional changes in the PR: - Update poetry installation command - ref: https://python-poetry.org/docs/master/#installing-with-the-official-installer - Remove pypi docker compose in ci image (docker-compose now comes from inside docker image anyway)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noticed by some users in the original PR, the changes were breaking ones and unjustified regarding the value offered in counter part.
This reverts commit 56e6c33, reversing
changes made to 0ab97a2.