fix: input and output signals are listed in properties#1549
fix: input and output signals are listed in properties#1549vogloblinsky merged 2 commits intocompodoc:developfrom
Conversation
|
Hi @vogloblinsky this PR fixes the current issues with |
|
Hi, |
Yes sure, can you give me a hint where I must add the unit test? |
ade5312 to
ecbf4da
Compare
|
|
ecbf4da to
22a3bc7
Compare
Thank you for the hint. I have added tests. |
|
@vogloblinsky is there anything else needed to get this PR merged? |
|
Please someone give some love to this PR before it becomes stale. This is one of the most critical issues with Compodoc now that Angular seems to have embraced signals. |
|
I would also love to see it merged and released soon. |
|
@vogloblinsky Sorry to tag you again, but it would be fantastic if this PR could be merged soon 🙂 |
|
Thanks a lot for the PR |
|
Unit tests are wrong, but may be not in sync with last developments, i will fix that asap. |
|
Hey @vogloblinsky what is the current progress of this? When can we expect a new release containing this PR? |
|
@vogloblinsky will this be released to NPM soon? We really need this fix for storybook. |
|
@kklimczak cool!! does it work with inputs with variable default value and transform functions? |
|
@rojasjandro89 Is it valid? In my case |
|
@kklimczak my bad, we can't specify a initial values in a required input. Can you try removing |
|
Is there any info on when we can expect this to be released? |
|
Hi Vincent, I wanted to ask if you have any plans to publish a new release that includes this fix for Angular signals? At the moment, without this fix, Storybook (which depends on your library) can't properly display fields using Angular signals, and it's causing some trouble in my workflow. Really appreciate your time and effort - let me know if there's anything I can do to help move this forward. Best regards, |
|
@sonallux unit tests are failing in the develop branch and it looks that started with the merger of this PR. I'm guessing that is the reason this hasn't been released to npm yet. Have you looked at this at all? |
|
@sonallux I might have found the issue. You change this function to assign to
if (IO.properties) {
- deps.properties = IO.properties;
+ deps.propertiesClass = properties;
} |
Followup fix for bug introduced in compodoc#1549
@vogloblinsky Now that unit tests are fixed, can we please get a new patch version with this change released to npm? |





Currently all
input,outputandmodelsignals are listed twice in the properties section and in the inputs or outputs section. See this screenshot after runningnpm run test:simple-doc:This PR fixes this bug by removing the entry in the properties section if it is a
input,outputormodelsignal. See this screenshot with this fix applied.If I should add tests for this change, could you please give me an advice where I can find the corresponding test file.