Add 'instance class fields / resolving identifier in parent scope'#1892
Merged
ljharb merged 1 commit intocompat-table:gh-pagesfrom Jun 19, 2024
Conversation
ljharb
reviewed
Jun 10, 2024
davidtaylorhq
commented
Jun 10, 2024
This is to detect https://bugs.webkit.org/show_bug.cgi?id=236843, which affects Safari 15 and below. Discussion in babel/babel#14289
e8732fe to
a40a7a2
Compare
davidtaylorhq
added a commit
to davidtaylorhq/babel
that referenced
this pull request
Jun 10, 2024
This is a workaround for https://bugs.webkit.org/show_bug.cgi?id=236843, and aims to resolve babel#14289. Pending: - acceptance of compat-table/compat-table#1892 - reviewing test failures
5 tasks
Contributor
|
I can confirm that this passes in Firefox 125 and Chrome 74. |
Contributor
|
Also Firefox 69 |
chicoxyzzy
approved these changes
Jun 19, 2024
ljharb
approved these changes
Jun 19, 2024
Contributor
|
Note: Firefox 69 and Chrome 74 are not included in this PR yet! @davidtaylorhq do you mind opening a new one? :) |
Contributor
Author
|
Thanks for the merge! Added those two extra data points in #1899 |
davidtaylorhq
added a commit
to davidtaylorhq/babel
that referenced
this pull request
Jul 10, 2024
This is a workaround for https://bugs.webkit.org/show_bug.cgi?id=236843, and aims to resolve babel#14289. Pending: - acceptance of compat-table/compat-table#1892 - reviewing test failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to detect https://bugs.webkit.org/show_bug.cgi?id=236843, which affects Safari 15 and below.
Discussion in babel/babel#14289