Rename "destructuring, parameters / defaults, arrow function"#1570
Merged
ljharb merged 3 commits intocompat-table:gh-pagesfrom Jan 17, 2020
nicolo-ribaudo:rename-arrow-destr-short-def-edge-bug
Merged
Rename "destructuring, parameters / defaults, arrow function"#1570ljharb merged 3 commits intocompat-table:gh-pagesfrom nicolo-ribaudo:rename-arrow-destr-short-def-edge-bug
ljharb merged 3 commits intocompat-table:gh-pagesfrom
nicolo-ribaudo:rename-arrow-destr-short-def-edge-bug
Conversation
It only tests shorthand defaults in object destructuring inside parameters, so "shorthand defaults, arrow function" describes it more closely. I propose to rename this test instead of also testing for `x: y = z` because the latter works in edge15-17, while the shorthand version doesn't.
Member
|
Do we then need a separate test for the shorthand version? |
Contributor
Author
|
Good idea, but I don't have any old browser to test it. |
Member
|
I'm happy to load up old edge versions in browserstack to add some results if you make the test first :-) |
Contributor
Author
|
|
Member
|
hmm, looks like I only have edge 15 and 11 available ("aliased defaults, arrow function" works in 15, syntax errors in 11). Let's clear out the 13/14 results for now. |
Contributor
Author
|
Is it possible to mark |
Member
|
We currently just leave them unspecified (ie, delete the entries) |
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jan 21, 2020
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jan 21, 2020
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jan 27, 2020
nicolo-ribaudo
added a commit
to babel/babel
that referenced
this pull request
Jan 27, 2020
* Fix compat-data build script * Update compat table * Update mappings for transform-parameters compat-table/compat-table#1570 * Update unrelated fixture * Update
rajasekarm
pushed a commit
to rajasekarm/babel
that referenced
this pull request
Feb 17, 2020
* Fix compat-data build script * Update compat table * Update mappings for transform-parameters compat-table/compat-table#1570 * Update unrelated fixture * Update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It only tests shorthand defaults in object destructuring inside parameters, so
"shorthand defaults, arrow function" describes it more closely.
I propose to rename this test instead of also testing for
x: y = zbecause thelatter works in edge15-17, while the shorthand version doesn't.