Skip to content

Changed the update metadata process to be initiated [#2059]#2060

Merged
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2059
Jun 16, 2024
Merged

Changed the update metadata process to be initiated [#2059]#2060
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-2059

Conversation

@mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Jun 16, 2024

  • Added a chunk listener for step notifications.
  • Added a job listener for jo notifications.
  • Removed the updateMetadata comic state event.
  • Changed the comic state machine for updating metadata.

Closes #2059

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Jun 16, 2024
@mcpierce mcpierce added this to the 2.1 milestone Jun 16, 2024
@mcpierce mcpierce force-pushed the feature/issue-2059 branch from ca81815 to 0f7ebc2 Compare June 16, 2024 15:35
@mcpierce
Changed the update metadata process to be initiated [comixed#2059]
4c87c34 
 * Added a chunk listener for step notifications.
 * Added a job listener for jo notifications.
 * Removed the updateMetadata comic state event.
 * Changed the comic state machine for updating metadata.
@mcpierce mcpierce force-pushed the feature/issue-2059 branch from 0f7ebc2 to 4c87c34 Compare June 16, 2024 17:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcpierce mcpierce merged commit 73ab97c into comixed:main Jun 16, 2024
@mcpierce mcpierce deleted the feature/issue-2059 branch June 16, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement A pull request containing a a new feature, refactoring, or security improvement..

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

Updating metadata is a table-driven batch process.

1 participant

@mcpierce