Merged
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Golang recently started offering Debian Bookworm as the default distro for `golang:1.20`, which provides a newer version of RocksDB than what we support in cometbft-db. For now this pins the image to Bullseye, which is the base image we have been using for some time now. Signed-off-by: Thane Thomson <connect@thanethomson.com>
Contributor
Author
|
Please take note of 336c3c0: sometime in the past day, the default base OS for This pins our E2E image to Bullseye for now until we resolve cometbft/cometbft-db#58, after which we'll be able to use Bookworm with a newer version of RocksDB. |
Contributor
Should this be cherry-picked into |
3 tasks
3 tasks
DongLieu
pushed a commit
to DongCoNY/cometbft
that referenced
this pull request
May 13, 2024
* changelog: Clean up and reorder Signed-off-by: Thane Thomson <connect@thanethomson.com> * changelog: Add severity to security fixes Signed-off-by: Thane Thomson <connect@thanethomson.com> * changelog: Add missing entries Signed-off-by: Thane Thomson <connect@thanethomson.com> * changelog: Release v0.37.2 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Rebuild changelog Signed-off-by: Thane Thomson <connect@thanethomson.com> * version: Bump to v0.37.2 Signed-off-by: Thane Thomson <connect@thanethomson.com> * test/e2e: Use Debian Bullseye as base image Golang recently started offering Debian Bookworm as the default distro for `golang:1.20`, which provides a newer version of RocksDB than what we support in cometbft-db. For now this pins the image to Bullseye, which is the base image we have been using for some time now. Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 CHANGELOG rendered
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments