Add requirement for CheckTx in ABCI spec (backport #928)#965
Merged
sergio-mena merged 3 commits intov0.37.xfrom Jun 14, 2023
Merged
Add requirement for CheckTx in ABCI spec (backport #928)#965sergio-mena merged 3 commits intov0.37.xfrom
CheckTx in ABCI spec (backport #928)#965sergio-mena merged 3 commits intov0.37.xfrom
Conversation
* Add requirement for `CheckTx` in ABCI spec * Apply suggestions from code review Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> * Added sentence from @jmalicevic's suggestion * Addressed review comments * Update spec/abci/abci++_app_requirements.md Co-authored-by: Daniel <daniel.cason@informal.systems> * Addressed comment * `CheckTx` requirements for the app, new version * New version of `CheckTx` requirement, after yesterday's discussion * Update spec/abci/abci++_app_requirements.md Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> * Addressed @josef-widder's comment --------- Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> Co-authored-by: Daniel <daniel.cason@informal.systems> (cherry picked from commit 21e94a2) # Conflicts: # spec/abci/abci++_app_requirements.md
* Add requirement for `CheckTx` in ABCI spec * Apply suggestions from code review Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> * Added sentence from @jmalicevic's suggestion * Addressed review comments * Update spec/abci/abci++_app_requirements.md Co-authored-by: Daniel <daniel.cason@informal.systems> * Addressed comment * `CheckTx` requirements for the app, new version * New version of `CheckTx` requirement, after yesterday's discussion * Update spec/abci/abci++_app_requirements.md Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> * Addressed @josef-widder's comment --------- Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> Co-authored-by: Daniel <daniel.cason@informal.systems>
sergio-mena
approved these changes
Jun 14, 2023
3 tasks
DongLieu
pushed a commit
to DongCoNY/cometbft
that referenced
this pull request
May 13, 2024
…ometbft#965) * Add requirement for `CheckTx` in ABCI spec (cometbft#928) * Add requirement for `CheckTx` in ABCI spec * Apply suggestions from code review Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> * Added sentence from @jmalicevic's suggestion * Addressed review comments * Update spec/abci/abci++_app_requirements.md Co-authored-by: Daniel <daniel.cason@informal.systems> * Addressed comment * `CheckTx` requirements for the app, new version * New version of `CheckTx` requirement, after yesterday's discussion * Update spec/abci/abci++_app_requirements.md Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> * Addressed @josef-widder's comment --------- Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> Co-authored-by: Daniel <daniel.cason@informal.systems> (cherry picked from commit 21e94a2) # Conflicts: # spec/abci/abci++_app_requirements.md * Revert "Add requirement for `CheckTx` in ABCI spec (cometbft#928)" * Add requirement for `CheckTx` in ABCI spec (cometbft#928) * Add requirement for `CheckTx` in ABCI spec * Apply suggestions from code review Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> * Added sentence from @jmalicevic's suggestion * Addressed review comments * Update spec/abci/abci++_app_requirements.md Co-authored-by: Daniel <daniel.cason@informal.systems> * Addressed comment * `CheckTx` requirements for the app, new version * New version of `CheckTx` requirement, after yesterday's discussion * Update spec/abci/abci++_app_requirements.md Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> * Addressed @josef-widder's comment --------- Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> Co-authored-by: Daniel <daniel.cason@informal.systems> --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com> Co-authored-by: Lasaro <lasaro@informal.systems> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> Co-authored-by: Daniel <daniel.cason@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #928 done by Mergify.
Cherry-pick of 21e94a2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com