Updated changelog with API changes in #286#748
Merged
sergio-mena merged 5 commits intov0.38.xfrom May 1, 2023
Merged
Conversation
lasarojc
approved these changes
Apr 24, 2023
Collaborator
Author
|
Changing the base branch to |
7773dae to
167f7a5
Compare
cason
approved these changes
Apr 25, 2023
Co-authored-by: Daniel <daniel.cason@informal.systems>
thanethomson
approved these changes
Apr 26, 2023
Contributor
thanethomson
left a comment
There was a problem hiding this comment.
You'd still need to run unclog build > CHANGELOG.md to propagate these changes to the changelog, otherwise they won't be immediately visible to alpha release users.
Collaborator
Author
Just pushed the result. There are some further changes, but I'm assuming those are some previous backports where we didn't run unclog. |
thanethomson
added a commit
that referenced
this pull request
Jul 14, 2023
thanethomson
added a commit
that referenced
this pull request
Jul 14, 2023
) * node: Revert removal of public reactor accessors (#1120) * Revert "Remove unused code (#286)" This reverts commit a2d9915. Signed-off-by: Thane Thomson <connect@thanethomson.com> * node: Remove access to consensus state Consensus state should only ever be accessible via the consensus reactor. Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com> * Fix mistake in changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 577cbcb) * Revert "Updated changelog with API changes in #286 (#748)" This reverts commit 7a253f1. Signed-off-by: Thane Thomson <connect@thanethomson.com> * Rebuild changelog with unreleased entries Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #747
Documents all the public methods removed from
Nodeand modified inSwitch, as part of #286.PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments