Mark the gRPC broadcast API as deprecated#651
Merged
thanethomson merged 1 commit intomainfrom Apr 5, 2023
Merged
Conversation
2 tasks
sergio-mena
approved these changes
Apr 5, 2023
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
LGTM.
You might want to merge this first to main, so when it is finally removed, the git-blame will clearly show the transition "deprecated" --> "removed"
baac2d7 to
131e20b
Compare
Signed-off-by: Thane Thomson <connect@thanethomson.com>
50c4755 to
1d17a31
Compare
mergify bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
Signed-off-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 66d4aae)
thanethomson
added a commit
that referenced
this pull request
Apr 5, 2023
* Deprecate gRPC broadcast API (#651) Signed-off-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 66d4aae) * Add changelog entry Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
thanethomson
added a commit
that referenced
this pull request
May 6, 2023
Signed-off-by: Thane Thomson <connect@thanethomson.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #650.
Changelog entry will be added to the v0.38.x backport.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments