Skip to content

Update CI and root docs on main for v0.38 release#597

Merged
thanethomson merged 6 commits intomainfrom
thane/595-prep-v0.38.x-ci
Mar 28, 2023
Merged

Update CI and root docs on main for v0.38 release#597
thanethomson merged 6 commits intomainfrom
thane/595-prep-v0.38.x-ci

Conversation

@thanethomson
Copy link
Contributor

Partially addresses #595.

Updates the CI config (adding nightly E2Es for the v0.38.x branch), as well as configures Mergify and Dependabot to behave in the same way as our v0.37.x and v0.34.x branches.

Also updates the README.md and RELEASES.md with some minor fixes (some of which we should partially propagate back to v0.37.x and v0.34.x at some point).


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from a team as a code owner March 28, 2023 00:38
@thanethomson thanethomson mentioned this pull request Mar 28, 2023
5 tasks
| Branch | Tests | Linting |
|---------|------------------------------------------------|---------------------------------------------|
| main | [![Tests][tests-badge]][tests-url] | [![Lint][lint-badge]][lint-url] |
| v0.38.x | [![Tests][tests-badge-v038x]][tests-url-v038x] | [![Lint][lint-badge-v038x]][lint-url-v038x] |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to highlight these images don't render, probably because the tests for v0.38 are not active yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the CI changes I've just pushed to #596 to be merged first before these images will render.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As expected, now that #596 has been merged, the images render.


Currently supported versions include:

- v0.38.x: CometBFT v0.38 introduces ABCI 2.0, which implements the entirety of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson merged commit 5d87896 into main Mar 28, 2023
@thanethomson thanethomson deleted the thane/595-prep-v0.38.x-ci branch March 28, 2023 14:59
@reneleonhardt
Copy link

@thanethomson I can't find a single successful run in the last 10 months:
https://github.com/unionlabs/cometbls/actions/workflows/e2e-nightly-38x.yml?query=is%3Asuccess

Why is v0.38 running against v1 tags?

Why is the target-branch set to v0.38.x which doesn't even exist?
https://github.com/unionlabs/cometbls/actions/runs/15988538759/job/45097353350#step:2:54

The same like v1.x which doesn't exist either:
https://github.com/unionlabs/cometbls/actions/runs/15988500042/job/45097245061#step:2:54

And 0.34 isn't even part of this repo anymore, no branch for that version.
https://github.com/unionlabs/cometbls/actions/runs/15988493505/job/45097227139#step:3:54

Why is dependabot not creating pull requests for the many outdated dependencies even when /api/go.mod hasn't been configured yet?

Why are issues disabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants