Skip to content

docs: improve Execute code block#534

Merged
adizere merged 1 commit intocometbft:mainfrom
rootulp:patch-1
Mar 20, 2023
Merged

docs: improve Execute code block#534
adizere merged 1 commit intocometbft:mainfrom
rootulp:patch-1

Conversation

@rootulp
Copy link
Contributor

@rootulp rootulp commented Mar 14, 2023

  1. InitialHeight is specified twice
  2. The contents of Execute refer to the parameter state not s

1. `InitialHeight` is specified twice
2. The contents of `Execute` refer to the parameter `state` not `s`
Copy link
Contributor

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @rootulp, nice catch!

@adizere adizere merged commit 9c5158a into cometbft:main Mar 20, 2023
mergify bot pushed a commit that referenced this pull request Mar 20, 2023
1. `InitialHeight` is specified twice
2. The contents of `Execute` refer to the parameter `state` not `s`

(cherry picked from commit 9c5158a)
mergify bot pushed a commit that referenced this pull request Mar 20, 2023
1. `InitialHeight` is specified twice
2. The contents of `Execute` refer to the parameter `state` not `s`

(cherry picked from commit 9c5158a)
@rootulp rootulp deleted the patch-1 branch March 20, 2023 09:10
adizere pushed a commit that referenced this pull request Mar 20, 2023
1. `InitialHeight` is specified twice
2. The contents of `Execute` refer to the parameter `state` not `s`

(cherry picked from commit 9c5158a)

Co-authored-by: Rootul P <rootulp@gmail.com>
adizere pushed a commit that referenced this pull request Mar 20, 2023
1. `InitialHeight` is specified twice
2. The contents of `Execute` refer to the parameter `state` not `s`

(cherry picked from commit 9c5158a)

Co-authored-by: Rootul P <rootulp@gmail.com>
roy-dydx pushed a commit to dydxprotocol/cometbft that referenced this pull request Jul 11, 2023
1. `InitialHeight` is specified twice
2. The contents of `Execute` refer to the parameter `state` not `s`

(cherry picked from commit 9c5158a)

Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants