chore: reindex to event sink from cli#5209
Merged
zrbecker merged 3 commits intocometbft:mainfrom Jun 24, 2025
Merged
Conversation
zrbecker
approved these changes
Jun 24, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
This adds a reindex command to the CLI interface. The command was already implemented, and included in a previous tendermint release (`0.34.x`) but the backport was missed during the tendermint -> cometbft transition. This is a useful command to repipe events to a destination sink, for example because of a migration, or if an event was lost because the sink was offline. This has been a recurring source of pain for us (Penumbra), and we didn't realize it existed until now. First, adding to `main`, and I will open backports to `0.38.x` and `0.37.x`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments Co-authored-by: Zachary Becker <zachary@interchainlabs.io> (cherry picked from commit c653eee)
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
This adds a reindex command to the CLI interface. The command was already implemented, and included in a previous tendermint release (`0.34.x`) but the backport was missed during the tendermint -> cometbft transition. This is a useful command to repipe events to a destination sink, for example because of a migration, or if an event was lost because the sink was offline. This has been a recurring source of pain for us (Penumbra), and we didn't realize it existed until now. First, adding to `main`, and I will open backports to `0.38.x` and `0.37.x`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments Co-authored-by: Zachary Becker <zachary@interchainlabs.io> (cherry picked from commit c653eee)
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
This adds a reindex command to the CLI interface. The command was already implemented, and included in a previous tendermint release (`0.34.x`) but the backport was missed during the tendermint -> cometbft transition. This is a useful command to repipe events to a destination sink, for example because of a migration, or if an event was lost because the sink was offline. This has been a recurring source of pain for us (Penumbra), and we didn't realize it existed until now. First, adding to `main`, and I will open backports to `0.38.x` and `0.37.x`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments Co-authored-by: Zachary Becker <zachary@interchainlabs.io> (cherry picked from commit c653eee)
This was referenced Jun 24, 2025
zrbecker
pushed a commit
that referenced
this pull request
Jun 25, 2025
This adds a reindex command to the CLI interface. The command was already implemented, and included in a previous tendermint release (`0.34.x`) but the backport was missed during the tendermint -> cometbft transition. This is a useful command to repipe events to a destination sink, for example because of a migration, or if an event was lost because the sink was offline. This has been a recurring source of pain for us (Penumbra), and we didn't realize it existed until now. First, adding to `main`, and I will open backports to `0.38.x` and `0.37.x`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #5209 done by [Mergify](https://mergify.com). Co-authored-by: Erwan Or <erwan.ounn.84@gmail.com> Co-authored-by: Zachary Becker <zachary@interchainlabs.io>
zrbecker
pushed a commit
that referenced
this pull request
Jun 25, 2025
This adds a reindex command to the CLI interface. The command was already implemented, and included in a previous tendermint release (`0.34.x`) but the backport was missed during the tendermint -> cometbft transition. This is a useful command to repipe events to a destination sink, for example because of a migration, or if an event was lost because the sink was offline. This has been a recurring source of pain for us (Penumbra), and we didn't realize it existed until now. First, adding to `main`, and I will open backports to `0.38.x` and `0.37.x`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #5209 done by [Mergify](https://mergify.com). Co-authored-by: Erwan Or <erwan.ounn.84@gmail.com> Co-authored-by: Zachary Becker <zachary@interchainlabs.io>
zrbecker
pushed a commit
that referenced
this pull request
Jun 25, 2025
This adds a reindex command to the CLI interface. The command was already implemented, and included in a previous tendermint release (`0.34.x`) but the backport was missed during the tendermint -> cometbft transition. This is a useful command to repipe events to a destination sink, for example because of a migration, or if an event was lost because the sink was offline. This has been a recurring source of pain for us (Penumbra), and we didn't realize it existed until now. First, adding to `main`, and I will open backports to `0.38.x` and `0.37.x`. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #5209 done by [Mergify](https://mergify.com). Co-authored-by: Erwan Or <erwan.ounn.84@gmail.com> Co-authored-by: Zachary Becker <zachary@interchainlabs.io>
Collaborator
|
Hi @zrbecker and @erwanor — quick note: I tried re-enabling this command before and ran into an edge case on archive nodes that span multiple CometBFT releases. My suspicion is schema/type changes across releases that break the command. A good validation is to run the command against an archive node that contains history from multiple releases; alternatively, reproduce locally by upgrading a test node through the older CometBFT versions and retesting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a reindex command to the CLI interface. The command was already implemented, and included in a previous tendermint release (
0.34.x) but the backport was missed during the tendermint -> cometbft transition. This is a useful command to repipe events to a destination sink, for example because of a migration, or if an event was lost because the sink was offline.This has been a recurring source of pain for us (Penumbra), and we didn't realize it existed until now. First, adding to
main, and I will open backports to0.38.xand0.37.x.PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments