Skip to content

ci: remove govulncheck#4946

Merged
melekes merged 1 commit intomainfrom
4945-remove-govulncheck
Feb 10, 2025
Merged

ci: remove govulncheck#4946
melekes merged 1 commit intomainfrom
4945-remove-govulncheck

Conversation

@melekes
Copy link
Copy Markdown
Collaborator

@melekes melekes commented Feb 10, 2025

Closes #4945

@melekes melekes requested a review from a team as a code owner February 10, 2025 06:16
@melekes melekes requested a review from a team February 10, 2025 06:16
@melekes melekes requested a review from a team as a code owner February 10, 2025 06:16
@melekes melekes self-assigned this Feb 10, 2025
@melekes melekes added the ci Continuous integration-related label Feb 10, 2025
@melekes
Copy link
Copy Markdown
Collaborator Author

melekes commented Feb 10, 2025

govulncheck must be removed from the required jobs list by the repo admin.

@melekes
Copy link
Copy Markdown
Collaborator Author

melekes commented Feb 10, 2025

govulncheck must be removed from the required jobs list by the repo admin.

cc @zrbecker

@melekes melekes enabled auto-merge February 10, 2025 06:38
@melekes melekes added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@melekes melekes added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@melekes melekes added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit c3ac62d Feb 10, 2025
31 checks passed
@melekes melekes deleted the 4945-remove-govulncheck branch February 10, 2025 06:57
@Zygimantass
Copy link
Copy Markdown

was it possible to exclude the MSRV check and keep all of the other ones?

@zrbecker zrbecker added backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x backport-to-v1.x labels Feb 18, 2025
mergify bot pushed a commit that referenced this pull request Feb 18, 2025
Closes #4945

(cherry picked from commit c3ac62d)

# Conflicts:
#	.github/workflows/govulncheck.yml
mergify bot pushed a commit that referenced this pull request Feb 18, 2025
Closes #4945

(cherry picked from commit c3ac62d)

# Conflicts:
#	.github/workflows/govulncheck.yml
#	Makefile
mergify bot added a commit that referenced this pull request Feb 18, 2025
Closes #4945
<hr>This is an automatic backport of pull request #4946 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Zachary Becker <zachary@interchainlabs.io>
zrbecker pushed a commit that referenced this pull request Feb 18, 2025
Closes #4945
<hr>This is an automatic backport of pull request #4946 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Zachary Becker <zachary@interchainlabs.io>
@melekes
Copy link
Copy Markdown
Collaborator Author

melekes commented Apr 17, 2025

was it possible to exclude the MSRV check and keep all of the other ones?

nope.

melekes added a commit to informalsystems/cometbft that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v0.38.x Tell Mergify to backport the PR to v0.38.x ci Continuous integration-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proposal: remove govulncheck CI job

3 participants