Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
| @@ -0,0 +1,2 @@ | |||
| - Use Go 1.19 to build CometBFT, since Go 1.18 has reached end-of-life. | |||
There was a problem hiding this comment.
Since there is #385 listed below, I'm not sure including this done achieves anything (think of a user reading these). It could even be misleading.
I'd remove this one
There was a problem hiding this comment.
I'll do this in a follow-up PR.
|
Question: let's say we backport something (next week) from |
This is a good question. I've been thinking about this recently, and I would say that we should probably only add changelog entries to PRs in two cases:
This way, when we cut a new release, it's easy to just copy across all the I'll see if there's an easy way to codify this in our PR template and contributing guidelines. |
Updates our root changelog and upgrading guidelines on
mainto sync them with what we have onv0.34.xandv0.37.x.Also makes a few minor changes to the README.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments