Merged
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Contributor
|
Hi, cannot upgrade as it will render our point version consensus breaking due to changes in go 1.19. |
Closed
sergio-mena
approved these changes
Feb 23, 2023
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Based on the latest discussion on Slack. I believe we can merge this now.
thanethomson
approved these changes
Feb 23, 2023
Contributor
thanethomson
left a comment
There was a problem hiding this comment.
Could we please add a changelog entry and a note in our upgrading guidelines for this?
Contributor
Author
Done! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #174
The SDK uses Go 1.18 from their release that integrates with v0.34, but they should upgrade
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments