fix(p2p/pex): do not send PEX request in fast dial mode#4644
Merged
jmalicevic merged 5 commits intomainfrom Dec 12, 2024
Merged
fix(p2p/pex): do not send PEX request in fast dial mode#4644jmalicevic merged 5 commits intomainfrom
jmalicevic merged 5 commits intomainfrom
Conversation
jmalicevic
reviewed
Dec 11, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
Solves #4620. Fixes an issue introduced by #3360. In short, when receiving addresses from a configured seed node, the peer immediately dials the received addresses, without waiting for the `defaultEnsurePeersPeriod` (30s). This is a desired behavior, the "fast dial mode" in the title. However, for preventing abuse, a node only accepts PEX requests from a peer every `minReceiveRequestInterval()` time, set to `defaultEnsurePeersPeriod/3` (10s). When running this "fast dial mode", however, a PEX request can be send, in some unlucky setup, to the same peer without waiting for the full defaultEnsurePeersPeriod` (30s). The problem is that at the receive side, a node keeps track of the latest PEX request received from each peer. If two requests are received with an interval lower than `minReceiveRequestInterval()`, the peer is considered abusive: it is disconnected with an `ErrReceivedPEXRequestTooSoon` error and banned from the address book. This PR proposes a workaround to prevent the above mentioned scenario. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 491379f) # Conflicts: # p2p/pex/pex_reactor.go
mergify bot
added a commit
that referenced
this pull request
Dec 12, 2024
Solves #4620. Fixes an issue introduced by #3360. In short, when receiving addresses from a configured seed node, the peer immediately dials the received addresses, without waiting for the `defaultEnsurePeersPeriod` (30s). This is a desired behavior, the "fast dial mode" in the title. However, for preventing abuse, a node only accepts PEX requests from a peer every `minReceiveRequestInterval()` time, set to `defaultEnsurePeersPeriod/3` (10s). When running this "fast dial mode", however, a PEX request can be send, in some unlucky setup, to the same peer without waiting for the full defaultEnsurePeersPeriod` (30s). The problem is that at the receive side, a node keeps track of the latest PEX request received from each peer. If two requests are received with an interval lower than `minReceiveRequestInterval()`, the peer is considered abusive: it is disconnected with an `ErrReceivedPEXRequestTooSoon` error and banned from the address book. This PR proposes a workaround to prevent the above mentioned scenario. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 491379f)
This was referenced Dec 12, 2024
jmalicevic
added a commit
that referenced
this pull request
Dec 12, 2024
jmalicevic
pushed a commit
that referenced
this pull request
Dec 12, 2024
This was referenced Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #4620.
Fixes an issue introduced by #3360.
In short, when receiving addresses from a configured seed node, the peer immediately dials the received addresses, without waiting for the
defaultEnsurePeersPeriod(30s). This is a desired behavior, the "fast dial mode" in the title.However, for preventing abuse, a node only accepts PEX requests from a peer every
minReceiveRequestInterval()time, set todefaultEnsurePeersPeriod/3(10s). When running this "fast dial mode", however, a PEX request can be send, in some unlucky setup, to the same peer without waiting for the full defaultEnsurePeersPeriod` (30s).The problem is that at the receive side, a node keeps track of the latest PEX request received from each peer. If two requests are received with an interval lower than
minReceiveRequestInterval(), the peer is considered abusive: it is disconnected with anErrReceivedPEXRequestTooSoonerror and banned from the address book.This PR proposes a workaround to prevent the above mentioned scenario.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments