build(deps): Mock generation no longer uses the latest tag on mockery.#4605
Merged
build(deps): Mock generation no longer uses the latest tag on mockery.#4605
latest tag on mockery.#4605Conversation
Using `latest` for `mockery` causes changes in the mocks with almost every new release, which in turn makes our CI fail. By fixing `mockery`'s version, we can prevent this issue. Additionally, `mockery`'s documentation suggests not to use `latest` anyway, so we were doing it incorrectly from the start.
jmalicevic
approved these changes
Dec 4, 2024
Collaborator
jmalicevic
left a comment
There was a problem hiding this comment.
Can you please follow up with the backport PRs? I think you will have to checkout the branches and regenerate the mocks before merging the change, otherwise the CI will fail on those branches.
Thanks for this!
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…ery`. (#4605) ### Context Using `latest` for `mockery` causes changes in the mocks with almost every new release, which in turn makes our CI fail. By fixing `mockery`'s version, we can prevent this issue. Additionally, `mockery`'s documentation suggests not to use `latest` anyway, so we were doing it incorrectly from the start. ### Changes This PR pins the `mockery` version to `v2.49.2` (the latest release). The `main` branch already uses mocks generated with this version, so using any other version of `mockery` would alter the mocks again. At least we get the benefit from the latest bug fixes. --- #### PR checklist - ~[ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ (cherry picked from commit 13d852b)
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…ery`. (#4605) ### Context Using `latest` for `mockery` causes changes in the mocks with almost every new release, which in turn makes our CI fail. By fixing `mockery`'s version, we can prevent this issue. Additionally, `mockery`'s documentation suggests not to use `latest` anyway, so we were doing it incorrectly from the start. ### Changes This PR pins the `mockery` version to `v2.49.2` (the latest release). The `main` branch already uses mocks generated with this version, so using any other version of `mockery` would alter the mocks again. At least we get the benefit from the latest bug fixes. --- #### PR checklist - ~[ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ (cherry picked from commit 13d852b) # Conflicts: # .changelog/v0.38.12/dependencies/4605-fix-mockery-version.md
This was referenced Dec 4, 2024
Merged
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…ery`. (#4605) ### Context Using `latest` for `mockery` causes changes in the mocks with almost every new release, which in turn makes our CI fail. By fixing `mockery`'s version, we can prevent this issue. Additionally, `mockery`'s documentation suggests not to use `latest` anyway, so we were doing it incorrectly from the start. ### Changes This PR pins the `mockery` version to `v2.49.2` (the latest release). The `main` branch already uses mocks generated with this version, so using any other version of `mockery` would alter the mocks again. At least we get the benefit from the latest bug fixes. --- #### PR checklist - ~[ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ (cherry picked from commit 13d852b) # Conflicts: # .changelog/v0.37.11/dependencies/4605-fix-mockery-version.md
Merged
1 task
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…ery`. (#4605) ### Context Using `latest` for `mockery` causes changes in the mocks with almost every new release, which in turn makes our CI fail. By fixing `mockery`'s version, we can prevent this issue. Additionally, `mockery`'s documentation suggests not to use `latest` anyway, so we were doing it incorrectly from the start. ### Changes This PR pins the `mockery` version to `v2.49.2` (the latest release). The `main` branch already uses mocks generated with this version, so using any other version of `mockery` would alter the mocks again. At least we get the benefit from the latest bug fixes. --- #### PR checklist - ~[ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ (cherry picked from commit 13d852b) # Conflicts: # scripts/mockery_generate.sh
Merged
1 task
alesforz
pushed a commit
that referenced
this pull request
Dec 4, 2024
…ery`. (backport #4605) (#4607) ### Context Using `latest` for `mockery` causes changes in the mocks with almost every new release, which in turn makes our CI fail. By fixing `mockery`'s version, we can prevent this issue. Additionally, `mockery`'s documentation suggests not to use `latest` anyway, so we were doing it incorrectly from the start. ### Changes This PR pins the `mockery` version to `v2.49.2` (the latest release). The `main` branch already uses mocks generated with this version, so using any other version of `mockery` would alter the mocks again. At least we get the benefit from the latest bug fixes.
alesforz
pushed a commit
that referenced
this pull request
Dec 4, 2024
…ery`. (backport #4605) (#4608) ### Context Using `latest` for `mockery` causes changes in the mocks with almost every new release, which in turn makes our CI fail. By fixing `mockery`'s version, we can prevent this issue. Additionally, `mockery`'s documentation suggests not to use `latest` anyway, so we were doing it incorrectly from the start. ### Changes This PR pins the `mockery` version to `v2.49.2` (the latest release). The `main` branch already uses mocks generated with this version, so using any other version of `mockery` would alter the mocks again. At least we get the benefit from the latest bug fixes.
alesforz
pushed a commit
that referenced
this pull request
Dec 4, 2024
…ery`. (backport #4605) (#4609) ### Context Using `latest` for `mockery` causes changes in the mocks with almost every new release, which in turn makes our CI fail. By fixing `mockery`'s version, we can prevent this issue. Additionally, `mockery`'s documentation suggests not to use `latest` anyway, so we were doing it incorrectly from the start. ### Changes This PR pins the `mockery` version to `v2.49.2` (the latest release). The `main` branch already uses mocks generated with this version, so using any other version of `mockery` would alter the mocks again. At least we get the benefit from the latest bug fixes.
alesforz
pushed a commit
that referenced
this pull request
Dec 4, 2024
…ery`. (backport #4605) (#4610) ### Context Using `latest` for `mockery` causes changes in the mocks with almost every new release, which in turn makes our CI fail. By fixing `mockery`'s version, we can prevent this issue. Additionally, `mockery`'s documentation suggests not to use `latest` anyway, so we were doing it incorrectly from the start. ### Changes This PR pins the `mockery` version to `v2.49.2` (the latest release). The `main` branch already uses mocks generated with this version, so using any other version of `mockery` would alter the mocks again. At least we get the benefit from the latest bug fixes.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Using
latestformockerycauses changes in the mocks with almost every new release, which in turn makes our CI fail. By fixingmockery's version, we can prevent this issue. Additionally,mockery's documentation suggests not to uselatestanyway, so we were doing it incorrectly from the start.Changes
This PR pins the
mockeryversion tov2.49.2(the latest release). Themainbranch already uses mocks generated with this version, so using any other version ofmockerywould alter the mocks again. At least we get the benefit from the latest bug fixes.PR checklist
[ ] Tests written/updated.changelog(we use unclog to manage our changelog)[ ] Updated relevant documentation (docs/orspec/) and code comments