feat(mocks): mockery v2.49.0 changes mock format#4521
Merged
jmalicevic merged 4 commits intomainfrom Nov 22, 2024
Merged
Conversation
mockery v2.49.0 changes mock format
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
…#4523) This is no the final fix and has to be followed up with #4521 . Merging this will make all the PRs currently open against main pass. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
alesforz
approved these changes
Nov 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
This PR generates new mocks because the version of mockery changes. Marking it as draft until all tests pass. The resolution comes from vektra/mockery#848 . We should think of a way to make our mocks compatible with the upcoming `v3` release. --- #### PR checklist - [ ] Tests written/updated - [x ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit cdab56d)
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
This PR generates new mocks because the version of mockery changes. Marking it as draft until all tests pass. The resolution comes from vektra/mockery#848 . We should think of a way to make our mocks compatible with the upcoming `v3` release. --- #### PR checklist - [ ] Tests written/updated - [x ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit cdab56d)
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
This PR generates new mocks because the version of mockery changes. Marking it as draft until all tests pass. The resolution comes from vektra/mockery#848 . We should think of a way to make our mocks compatible with the upcoming `v3` release. --- #### PR checklist - [ ] Tests written/updated - [x ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit cdab56d) # Conflicts: # scripts/mockery_generate.sh
This was referenced Nov 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
This PR generates new mocks because the version of mockery changes. Marking it as draft until all tests pass. The resolution comes from vektra/mockery#848 . We should think of a way to make our mocks compatible with the upcoming `v3` release. --- #### PR checklist - [ ] Tests written/updated - [x ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit cdab56d) # Conflicts: # scripts/mockery_generate.sh
2 tasks
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
Adding changelog for #4521 --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
mergify bot
added a commit
that referenced
this pull request
Nov 25, 2024
…4525) This PR generates new mocks because the version of mockery changes. Marking it as draft until all tests pass. The resolution comes from vektra/mockery#848 . We should think of a way to make our mocks compatible with the upcoming `v3` release. --- #### PR checklist - [ ] Tests written/updated - [x ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #4521 done by [Mergify](https://mergify.com). --------- Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
mergify bot
added a commit
that referenced
this pull request
Nov 25, 2024
…4528) This PR generates new mocks because the version of mockery changes. Marking it as draft until all tests pass. The resolution comes from vektra/mockery#848 . We should think of a way to make our mocks compatible with the upcoming `v3` release. --- #### PR checklist - [ ] Tests written/updated - [x ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #4521 done by [Mergify](https://mergify.com). --------- Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
mergify bot
added a commit
that referenced
this pull request
Nov 25, 2024
…4526) This PR generates new mocks because the version of mockery changes. Marking it as draft until all tests pass. The resolution comes from vektra/mockery#848 . We should think of a way to make our mocks compatible with the upcoming `v3` release. --- #### PR checklist - [ ] Tests written/updated - [x ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #4521 done by [Mergify](https://mergify.com). --------- Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Nov 25, 2024
…4527) This PR generates new mocks because the version of mockery changes. Marking it as draft until all tests pass. The resolution comes from vektra/mockery#848 . We should think of a way to make our mocks compatible with the upcoming `v3` release. --- #### PR checklist - [ ] Tests written/updated - [x ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #4521 done by [Mergify](https://mergify.com). --------- Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generates new mocks because the version of mockery changes. Marking it as draft until all tests pass.
The resolution comes from vektra/mockery#848 .
We should think of a way to make our mocks compatible with the upcoming
v3release.Changelog added #4529
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments