Skip to content

chore: updates in preparation for v1.0.0-rc2#4454

Merged
andynog merged 12 commits intomainfrom
andy/changelog-v1-rc2
Nov 20, 2024
Merged

chore: updates in preparation for v1.0.0-rc2#4454
andynog merged 12 commits intomainfrom
andy/changelog-v1-rc2

Conversation

@andynog
Copy link
Collaborator

@andynog andynog commented Nov 7, 2024 •
edited
Loading

Updates in preparation for v1.0.0-rc2:

  • summary.md
  • Tutorial instructions

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@andynog andynog added release Pull requests that facilitate cutting a release backport-to-v1.x labels Nov 7, 2024
@andynog andynog added this to the 2024-Q4 milestone Nov 7, 2024
@andynog andynog self-assigned this Nov 7, 2024
@andynog andynog requested a review from a team as a code owner November 7, 2024 19:34
@andynog andynog requested a review from a team November 7, 2024 19:34
@andynog andynog marked this pull request as draft November 7, 2024 19:35
@andynog andynog mentioned this pull request Nov 7, 2024
Closed
31 tasks
@andynog andynog changed the title chore: updating CHANGELOG for v1.0.0-rc2 chore: updates in preparation for v1.0.0-rc2 Nov 7, 2024
melekes
melekes reviewed Nov 8, 2024
View reviewed changes
cason
cason reviewed Nov 8, 2024
View reviewed changes
Copy link

@cason cason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

We have to pay attention to what goes to the CHANGELOG of this new release. It is kind of confusing because we are considering all unreleased changes, which include stuff that is only in main.

Nonetheless, some entries are poorly written and the description of some important changes is missing.

andynog and others added 2 commits November 8, 2024 15:51
@andynog
Update .changelog/unreleased/summary.md
a62830f 
Co-authored-by: Daniel <daniel.cason@informal.systems>
@andynog @melekes
Update .changelog/unreleased/summary.md
a89a1c0 
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
@andynog
Copy link
Collaborator Author

andynog commented Nov 8, 2024

We have to pay attention to what goes to the CHANGELOG of this new release. It is kind of confusing because we are considering all unreleased changes, which include stuff that is only in main.

@cason, yes, the CHANGELOG.md was added here but just because we tend to update it when we do a release. But since we are back porting this PR to v1.x we should not have the CHANGELOG.md in this PR. I'll exclude it. It is generated with unclog so we should not need to modify the file directly.

Then I will open another PR with the generated CHANGELOG.md in v1.x when we back port this and we agree on the content of summary and the .changelog entries.

Thanks !

@github-actions
Copy link

github-actions bot commented Nov 19, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale For use by stalebot label Nov 19, 2024
@andynog andynog removed the stale For use by stalebot label Nov 19, 2024
@andynog andynog marked this pull request as ready for review November 19, 2024 19:55
melekes
melekes approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andynog andynog added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 0cb58b5 Nov 20, 2024
@andynog andynog deleted the andy/changelog-v1-rc2 branch November 20, 2024 14:20
mergify bot pushed a commit that referenced this pull request Nov 20, 2024
@andynog @mergify
chore: updates in preparation for v1.0.0-rc2 (#4454)
17103e0 
Updates  in preparation for `v1.0.0-rc2`:

- `summary.md`
- Tutorial instructions

#### PR checklist

- [ ] Tests written/updated
- [X] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments

---------

Co-authored-by: Daniel <daniel.cason@informal.systems>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 0cb58b5)

# Conflicts:
#	.changelog/unreleased/summary.md
@mergify mergify bot mentioned this pull request Nov 20, 2024
Merged
3 tasks
andynog added a commit that referenced this pull request Nov 20, 2024
@mergify @andynog
chore: updates in preparation for v1.0.0-rc2 (backport #4454) (#4518)
067aefa 
Updates  in preparation for `v1.0.0-rc2`:

- `summary.md`
- Tutorial instructions

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cason cason cason left review comments

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andynog andynog

Labels

release Pull requests that facilitate cutting a release

Projects

No open projects
CometBFT
Status: Done

Milestone

2024-Q4

Development

Successfully merging this pull request may close these issues.

3 participants

@andynog @cason @melekes