fix(p2p): adjust backoff seconds to increase reconnect retries close to 24 hours (backport #4377)#4426
Merged
mergify[bot] merged 2 commits intov0.37.xfrom Nov 4, 2024
Merged
Conversation
…to 24 hours (#4377) close: #3519 Adjust `reconnectBackOffBaseSeconds` to increase reconnect retries to up 1 day (~24 hours). The new value can be validated here: https://go.dev/play/p/k8F5rS-i24p, which will show that the total time is increased to almost 24 hours. Initial reconnecting time: 2m8.493s Total reconnecting time. : 23h55m56.249s The `reconnectBackOffBaseSeconds` is increased by a bit over 10% (from 3.0 to 3.4 seconds) so this would not affect reconnection retries too much. #### PR checklist - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Daniel <daniel.cason@informal.systems> (cherry picked from commit 81f2763) # Conflicts: # .changelog/v0.37.7/improvements/3519-p2p-reconnect-interval-1day.md
Contributor
Author
|
Cherry-pick of 81f2763 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
andynog
approved these changes
Nov 4, 2024
Collaborator
andynog
left a comment
There was a problem hiding this comment.
lgtm, fixed changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #3519
Adjust
reconnectBackOffBaseSecondsto increase reconnect retries to up 1 day (~24 hours).The new value can be validated here: https://go.dev/play/p/k8F5rS-i24p, which will show that the total time is increased to almost 24 hours.
Initial reconnecting time: 2m8.493s
Total reconnecting time. : 23h55m56.249s
The
reconnectBackOffBaseSecondsis increased by a bit over 10% (from 3.0 to 3.4 seconds) so this would not affect reconnection retries too much.PR checklist
Tests written/updated.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsThis is an automatic backport of pull request #4377 done by [Mergify](https://mergify.com).