feat(types): increase default SynchronyParams consensus parameters values#4249
Merged
feat(types): increase default SynchronyParams consensus parameters values#4249
SynchronyParams consensus parameters values#4249Conversation
SynchronyParams valuesSynchronyParams values
SynchronyParams valuesSynchronyParams consensus parameters values
sergio-mena
reviewed
Oct 4, 2024
| return SynchronyParams{ | ||
| Precision: 500 * time.Millisecond, | ||
| MessageDelay: 2 * time.Second, | ||
| Precision: 505 * time.Millisecond, |
Collaborator
There was a problem hiding this comment.
Just curious, why 505 ms? (I mean, why the extra 5 ms)
Author
There was a problem hiding this comment.
No idea. It is more than 500, we could use 501, ehehe.
Author
There was a problem hiding this comment.
This is the number that Willian has adopted in the original implementation.
sergio-mena
approved these changes
Oct 4, 2024
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Thanks a lot for this 🙏
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
…values (#4249) Closes #4246 - `Precision` was set to `505ms`, because it should be greater than 0.5s, as in tendermint/tendermint#7724 - `MessageDelay` was increased to `15s`, following the measurements reported in tendermint/tendermint#7788, and considering some outputs of `e2e` tests --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit bbb86ce)
Merged
3 tasks
cason
pushed a commit
that referenced
this pull request
Oct 7, 2024
…values (backport #4249) (#4278) Closes #4246 - `Precision` was set to `505ms`, because it should be greater than 0.5s, as in tendermint/tendermint#7724 - `MessageDelay` was increased to `15s`, following the measurements reported in tendermint/tendermint#7788, and considering some outputs of `e2e` tests --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #4249 done by [Mergify](https://mergify.com). Co-authored-by: Daniel <daniel.cason@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4246
Precisionwas set to505ms, because it should be greater than 0.5s, as in Proposer-Based Timesamps leap second handling tendermint/tendermint#7724MessageDelaywas increased to15s, following the measurements reported in types: add default values for the synchrony parameters tendermint/tendermint#7788, and considering some outputs ofe2etestsPR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments