Skip to content

fix(mempool): change "mempool is full" log level to debug (backport #4123)#4144

Merged
mergify[bot] merged 3 commits intov1.xfrom
mergify/bp/v1.x/pr-4123
Sep 20, 2024
Merged

fix(mempool): change "mempool is full" log level to debug (backport #4123)#4144
mergify[bot] merged 3 commits intov1.xfrom
mergify/bp/v1.x/pr-4123

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 20, 2024

it happens in benchmark or production when traffic is high, the log frequency is very high because it's triggered by p2p tx propagation message.

Solution:

  • change it to debug level

This is an automatic backport of pull request #4123 done by [Mergify](https://mergify.com).

it happens in benchmark or production when traffic is high, the log
frequency is very high because it's triggered by p2p tx propagation
message.

Solution:
- change it to debug level

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 1323b1c)

# Conflicts:
#	mempool/reactor.go
@mergify mergify bot requested a review from a team as a code owner September 20, 2024 18:04
@mergify mergify bot added the conflicts label Sep 20, 2024
@mergify mergify bot requested a review from a team September 20, 2024 18:04
@mergify
Copy link
Contributor Author

mergify bot commented Sep 20, 2024

Cherry-pick of 1323b1c has failed:

On branch mergify/bp/v1.x/pr-4123
Your branch is up to date with 'origin/v1.x'.

You are currently cherry-picking commit 1323b1cdd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changelog/unreleased/improvements/4123-mempool-is-full-log.md
	modified:   mempool/clist_mempool.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   mempool/reactor.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@andynog andynog self-assigned this Sep 20, 2024
Copy link
Collaborator

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit 26c070a into v1.x Sep 20, 2024
@mergify mergify bot deleted the mergify/bp/v1.x/pr-4123 branch September 20, 2024 21:02
@jmalicevic jmalicevic added this to the 2024-Q3 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants