test(mempool): enhanced TestReactorNoBroadcastToSender#4127
Merged
Conversation
melekes
reviewed
Sep 20, 2024
Collaborator
|
Now that the mempool has lanes, the generated transactions will be assigned to different lanes, therefore they will arrive to the second node in a different order than FIFO. So one way to fix the test is to change the last line to only check that txs have arrived to the second reactor's mempool (with If you still want to check that they have arrived in order, don't use lanes in this test. That will require more changes in the auxiliary functions because you will need to create the apps without lanes, with |
hvanz
approved these changes
Sep 26, 2024
Collaborator
hvanz
left a comment
There was a problem hiding this comment.
Thanks for improving the test! As mentioned elsewhere, it would be better to test also the case with more than one lane, but the test in this PR is already better than the original one.
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
The test should be able now to catch the error introduced by #3657. ---- To see how it would break, please checkout the branch `cason/test-nobroadcastsender`, then: ``` $ cd mempool $ go test -v -run TestReactorNoBroadcastToSender ``` And wait it to fail, after 2 minutes. You are going to see the busy-loop around, logs entries starting with `Skipping tx`, forever for the same transaction. Important: the test unit only works in the traditional mempool design, without lanes. We should consider adding a variant of it that should also pass when lanes are considered. --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 9e25845) # Conflicts: # mempool/reactor.go # mempool/reactor_test.go
3 tasks
mergify bot
added a commit
that referenced
this pull request
Sep 27, 2024
) (#4182) The test should be able now to catch the error introduced by #3657. FOR REVIEWERS: the 91ab7a7 commit was reverted in this backport, since mempool lanes is not implemented in `v1.x`. #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #4127 done by [Mergify](https://mergify.com). --------- Co-authored-by: Daniel <daniel.cason@informal.systems>
hvanz
pushed a commit
to InjectiveLabs/cometbft
that referenced
this pull request
Mar 12, 2025
The test should be able now to catch the error introduced by cometbft#3657. ---- To see how it would break, please checkout the branch `cason/test-nobroadcastsender`, then: ``` $ cd mempool $ go test -v -run TestReactorNoBroadcastToSender ``` And wait it to fail, after 2 minutes. You are going to see the busy-loop around, logs entries starting with `Skipping tx`, forever for the same transaction. Important: the test unit only works in the traditional mempool design, without lanes. We should consider adding a variant of it that should also pass when lanes are considered. --- - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
maxim-inj
pushed a commit
to InjectiveLabs/cometbft
that referenced
this pull request
Mar 15, 2025
The test should be able now to catch the error introduced by cometbft#3657. ---- To see how it would break, please checkout the branch `cason/test-nobroadcastsender`, then: ``` $ cd mempool $ go test -v -run TestReactorNoBroadcastToSender ``` And wait it to fail, after 2 minutes. You are going to see the busy-loop around, logs entries starting with `Skipping tx`, forever for the same transaction. Important: the test unit only works in the traditional mempool design, without lanes. We should consider adding a variant of it that should also pass when lanes are considered. --- - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test should be able now to catch the error introduced by #3657.
To see how it would break, please checkout the branch
cason/test-nobroadcastsender, then:And wait it to fail, after 2 minutes. You are going to see the busy-loop around, logs entries starting with
Skipping tx, forever for the same transaction.Important: the test unit only works in the traditional mempool design, without lanes. We should consider adding a variant of it that should also pass when lanes are considered.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments