test(blocksync): increase capacity of errorsCh#4125
Merged
Conversation
similar to how we set capacity to 1000 in production to avoid locking. ```go const capacity = 1000 // must be bigger than peers count errorsCh := make(chan peerError, capacity) // so we don't block in #Receive#pool.AddBlock ``` https://github.com/cometbft/cometbft/blob/main/internal/blocksync/reactor.go#L99C1-L100C91
This comment was marked as resolved.
This comment was marked as resolved.
mergify bot
added a commit
that referenced
this pull request
Sep 20, 2024
similar to how we set capacity to 1000 in production to avoid locking. ```go const capacity = 1000 // must be bigger than peers count errorsCh := make(chan peerError, capacity) // so we don't block in #Receive#pool.AddBlock ``` https://github.com/cometbft/cometbft/blob/main/internal/blocksync/reactor.go#L99C1-L100C91 --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 8a7a640)
melekes
added a commit
that referenced
this pull request
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
similar to how we set capacity to 1000 in production to avoid locking.
https://github.com/cometbft/cometbft/blob/main/internal/blocksync/reactor.go#L99C1-L100C91