build(deps): Bump minimum Go version to v1.23 by melekes · Pull Request #4041 · cometbft/cometbft

melekes · 2024-09-09T08:29:42Z

cometbft-db PR: cometbft/cometbft-db#194

PR checklist

~~Tests written/updated~~
Changelog entry added in .changelog (we use unclog to manage our changelog)
Updated relevant documentation (docs/ or spec/) and code comments

melekes · 2024-09-11T10:18:40Z

==================
WARNING: DATA RACE
Write at 0x00c000396570 by goroutine 25:
  github.com/cometbft/cometbft/internal/autofile.(*Group).RotateFile()
      /Users/antonk/work/informal/cometbft/internal/autofile/group.go:317 +0x214
  github.com/cometbft/cometbft/internal/autofile.(*Group).checkHeadSizeLimit()
      /Users/antonk/work/informal/cometbft/internal/autofile/group.go:255 +0x78
  github.com/cometbft/cometbft/internal/autofile.(*Group).processTicks()
      /Users/antonk/work/informal/cometbft/internal/autofile/group.go:235 +0xa0
  github.com/cometbft/cometbft/internal/autofile.(*Group).OnStart.gowrap1()
      /Users/antonk/work/informal/cometbft/internal/autofile/group.go:141 +0x34

Previous read at 0x00c000396570 by goroutine 20:
  github.com/cometbft/cometbft/internal/autofile.(*Group).MaxIndex()
      /Users/antonk/work/informal/cometbft/internal/autofile/group.go:184 +0x84
  github.com/cometbft/cometbft/internal/consensus.(*BaseWAL).SearchForEndHeight()
      /Users/antonk/work/informal/cometbft/internal/consensus/wal.go:244 +0x30
  github.com/cometbft/cometbft/internal/consensus.TestWALTruncate()
      /Users/antonk/work/informal/cometbft/internal/consensus/wal_test.go:76 +0x414
  github.com/syndtr/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:458 +0x364
  fmt.Fscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:143 +0x94
  fmt.Sscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:114 +0x1ec
  github.com/syndtr/goleveldb/leveldb/storage.fsParseName()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:657 +0x138
  fmt.(*ss).doScanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:1230 +0x328
  fmt.Fscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:143 +0x94
  fmt.Sscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:114 +0x130
  github.com/syndtr/goleveldb/leveldb/storage.fsParseName()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:643 +0x74
  github.com/syndtr/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:458 +0x364
  github.com/syndtr/goleveldb/leveldb.(*DB).checkAndCleanFiles()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db_util.go:52 +0x1d0
  github.com/syndtr/goleveldb/leveldb.openDB()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db.go:136 +0x674
  github.com/syndtr/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:458 +0x364
  fmt.Fscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:143 +0x94
  fmt.Sscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:114 +0x130
  github.com/syndtr/goleveldb/leveldb/storage.fsParseName()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:643 +0x74
  github.com/syndtr/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:458 +0x364
  fmt.Fscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:143 +0x94
  fmt.Sscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:114 +0x130
  github.com/syndtr/goleveldb/leveldb/storage.fsParseName()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:643 +0x74
  github.com/syndtr/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:458 +0x364
  fmt.Fscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:143 +0x94
  fmt.Sscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:114 +0x1ec
  github.com/syndtr/goleveldb/leveldb/storage.fsParseName()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:657 +0x138
  fmt.(*ss).doScanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:1230 +0x328
  fmt.Fscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:143 +0x94
  fmt.Sscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:114 +0x130
  github.com/syndtr/goleveldb/leveldb/storage.fsParseName()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:643 +0x74
  github.com/syndtr/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:458 +0x364
  github.com/syndtr/goleveldb/leveldb.(*DB).recoverJournal()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db.go:482 +0x84
  github.com/syndtr/goleveldb/leveldb.openDB()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db.go:131 +0x668
  github.com/syndtr/goleveldb/leveldb.Open()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db.go:203 +0x274
  fmt.Fscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:143 +0x94
  fmt.Sscanf()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/fmt/scan.go:114 +0x130
  github.com/syndtr/goleveldb/leveldb/storage.fsParseName()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:643 +0x74
  github.com/syndtr/goleveldb/leveldb/storage.(*fileStorage).List()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/storage/file_storage.go:458 +0x364
  github.com/syndtr/goleveldb/leveldb.(*session).recover.func1()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/session.go:134 +0xb4
  runtime.deferreturn()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/runtime/panic.go:605 +0x5c
  github.com/syndtr/goleveldb/leveldb.Open()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db.go:189 +0xb0
  github.com/syndtr/goleveldb/leveldb.OpenFile()
      /Users/antonk/go/pkg/mod/github.com/syndtr/goleveldb@v1.0.1-0.20210819022825-2ae1ddf74ef7/leveldb/db.go:225 +0x6c
  github.com/cometbft/cometbft-db.NewGoLevelDBWithOpts()
      /Users/antonk/go/pkg/mod/github.com/cometbft/cometbft-db@v0.15.0/goleveldb.go:32 +0xa8
  github.com/cometbft/cometbft-db.NewGoLevelDB()
      /Users/antonk/go/pkg/mod/github.com/cometbft/cometbft-db@v0.15.0/goleveldb.go:27 +0x48
  github.com/cometbft/cometbft/abci/example/kvstore.NewPersistentApplication()
      /Users/antonk/work/informal/cometbft/abci/example/kvstore/kvstore.go:65 +0x2c
  github.com/cometbft/cometbft/internal/consensus.WALGenerateNBlocks()
      /Users/antonk/work/informal/cometbft/internal/consensus/wal_generator.go:34 +0xfc
  github.com/cometbft/cometbft/internal/consensus.TestWALTruncate()
      /Users/antonk/work/informal/cometbft/internal/consensus/wal_test.go:66 +0x350
  testing.tRunner()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1690 +0x184
  testing.(*T).Run.gowrap1()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1743 +0x40

Goroutine 25 (running) created at:
  github.com/cometbft/cometbft/internal/autofile.(*Group).OnStart()
      /Users/antonk/work/informal/cometbft/internal/autofile/group.go:141 +0xe8
  github.com/cometbft/cometbft/libs/service.(*BaseService).Start()
      /Users/antonk/work/informal/cometbft/libs/service/service.go:146 +0x4a8
  github.com/cometbft/cometbft/internal/consensus.(*BaseWAL).OnStart()
      /Users/antonk/work/informal/cometbft/internal/consensus/wal.go:134 +0xa4
  github.com/cometbft/cometbft/libs/service.(*BaseService).Start()
      /Users/antonk/work/informal/cometbft/libs/service/service.go:146 +0x4a8
  github.com/cometbft/cometbft/internal/consensus.TestWALTruncate()
      /Users/antonk/work/informal/cometbft/internal/consensus/wal_test.go:52 +0x2a0
  testing.tRunner()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1690 +0x184
  testing.(*T).Run.gowrap1()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1743 +0x40

Goroutine 20 (running) created at:
  testing.(*T).Run()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1743 +0x5e0
  testing.runTests.func1()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:2168 +0x80
  testing.tRunner()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:1690 +0x184
  testing.runTests()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:2166 +0x6e0
  testing.(*M).Run()
      /opt/homebrew/Cellar/go/1.23.1/libexec/src/testing/testing.go:2034 +0xb74
  github.com/cometbft/cometbft/internal/consensus.TestMain()
      /Users/antonk/work/informal/cometbft/internal/consensus/replay_test.go:44 +0x168
  main.main()
      _testmain.go:259 +0x114
==================

https://go.dev/wiki/Go123Timer

andynog

lgtm, thanks @melekes

Closes #4039 cometbft-db PR: cometbft/cometbft-db#194 --- #### PR checklist - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit ff34f75) # Conflicts: # go.mod

Closes #4039 cometbft-db PR: cometbft/cometbft-db#194 --- #### PR checklist - [ ] ~~Tests written/updated~~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #4041 done by [Mergify](https://mergify.com). --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Andy Nogueira <me@andynogueira.dev>

build(deps): Bump minimum Go version to v1.23

3ccd964

melekes requested a review from a team as a code owner September 9, 2024 08:29

melekes requested a review from a team September 9, 2024 08:29

melekes linked an issue Sep 9, 2024 that may be closed by this pull request

GO-2024-3107 #4039

Closed

melekes self-assigned this Sep 9, 2024

melekes added the dependencies Dependency updates label Sep 9, 2024

melekes added 2 commits September 9, 2024 12:48

github workflow version bump

b782147

update cometbft-db version

92097cb

andynog mentioned this pull request Sep 9, 2024

docs: fix godoc in GenFilePV #4044

Merged

1 task

This comment was marked as resolved.

Sign in to view

melekes added 2 commits September 11, 2024 12:53

Merge branch 'main' into 4039-go-2024-3107

7b81dda

update readme

0312ddb

melekes added 2 commits September 11, 2024 14:31

no need to drain the stale value

ccffc3b

https://go.dev/wiki/Go123Timer

no need to drain the timer

c91b69a

melekes added the backport-to-v1.x label Sep 11, 2024

Merge branch 'main' into 4039-go-2024-3107

1adad2e

andynog approved these changes Sep 11, 2024

View reviewed changes

andynog added this pull request to the merge queue Sep 11, 2024

Merged via the queue into main with commit ff34f75 Sep 11, 2024

andynog deleted the 4039-go-2024-3107 branch September 11, 2024 21:57

mergify bot mentioned this pull request Sep 11, 2024

build(deps): Bump minimum Go version to v1.23 (backport #4041) #4086

Merged

3 tasks

andynog added a commit that referenced this pull request Sep 11, 2024

fixing conflict (#4041)

4e3ce24

andynog added a commit that referenced this pull request Sep 11, 2024

fixing dependencies (#4041)

37143c3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(deps): Bump minimum Go version to v1.23#4041

build(deps): Bump minimum Go version to v1.23#4041
andynog merged 8 commits intomainfrom
4039-go-2024-3107

melekes commented Sep 9, 2024 •

edited

Loading

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

melekes commented Sep 11, 2024

Uh oh!

andynog left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

melekes commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

melekes commented Sep 11, 2024

Uh oh!

andynog left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

melekes commented Sep 9, 2024 •

edited

Loading