Skip to content

Re-plot v0.37.x baseline graphs with new script#395

Merged
mergify[bot] merged 2 commits intomainfrom
sergio/qa_0.37.x-alpha3_baseline_plots
Feb 27, 2023
Merged

Re-plot v0.37.x baseline graphs with new script#395
mergify[bot] merged 2 commits intomainfrom
sergio/qa_0.37.x-alpha3_baseline_plots

Conversation

@sergio-mena
Copy link
Collaborator

@sergio-mena sergio-mena commented Feb 26, 2023

Contributes to #93 and #41

Rendered

Complementary to #376 (and analogous to what we did for CometBFT v0.34.x QA) this PR re-plots the baseline results, obtained in Oct 2022, using the newly developed python scripts.
The goal is to ease visual comparison between CometBFT v0.37.x and Tendermint Core baseline results when looking at the report.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@sergio-mena sergio-mena requested a review from a team as a code owner February 26, 2023 20:18
@sergio-mena sergio-mena self-assigned this Feb 26, 2023
@sergio-mena sergio-mena added documentation Improvements or additions to documentation backport-to-v0.37.x qa Quality assurance rename Renaming our fork labels Feb 26, 2023
This was referenced Feb 26, 2023
Copy link
Contributor

@lasarojc lasarojc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the plots and corresponding text.
lgtm

@mergify mergify bot merged commit c67d2f7 into main Feb 27, 2023
@mergify mergify bot deleted the sergio/qa_0.37.x-alpha3_baseline_plots branch February 27, 2023 09:51
mergify bot pushed a commit that referenced this pull request Feb 27, 2023
Contributes to #93 and #41

[Rendered](https://github.com/cometbft/cometbft/blob/sergio/qa_0.37.x-alpha3_baseline_plots/docs/qa/v037/CometBFT.md)

Complementary to #376 (and analogous to what we did for CometBFT `v0.34.x` QA) this PR re-plots the baseline results, obtained in Oct 2022, using the newly developed python scripts.
The goal is to ease visual comparison between CometBFT `v0.37.x` and Tendermint Core baseline results when looking at the report.

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code comments

(cherry picked from commit c67d2f7)
sergio-mena added a commit that referenced this pull request Feb 27, 2023
Contributes to #93 and #41

[Rendered](https://github.com/cometbft/cometbft/blob/sergio/qa_0.37.x-alpha3_baseline_plots/docs/qa/v037/CometBFT.md)

Complementary to #376 (and analogous to what we did for CometBFT `v0.34.x` QA) this PR re-plots the baseline results, obtained in Oct 2022, using the newly developed python scripts.
The goal is to ease visual comparison between CometBFT `v0.37.x` and Tendermint Core baseline results when looking at the report.

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code comments

(cherry picked from commit c67d2f7)

Co-authored-by: Sergio Mena <sergio@informal.systems>
noot pushed a commit to astriaorg/cometbft that referenced this pull request Jun 14, 2023
* Typo fix in README.md (cometbft#350)

* Updated Apalache type annotations (cometbft#395)

Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com>
Co-authored-by: Kukovec <jure.kukovec@gmail.com>
golden-curve pushed a commit to 1119-Labs/cometbft that referenced this pull request Jan 19, 2026
* Typo fix in README.md (cometbft#350)

* Updated Apalache type annotations (cometbft#395)

Co-authored-by: Prajjwol Gautam <prajjwol@gmail.com>
Co-authored-by: Kukovec <jure.kukovec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge documentation Improvements or additions to documentation qa Quality assurance rename Renaming our fork

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants