docs: Archive Tendermint Core ADRs/RFCs#393
Merged
thanethomson merged 6 commits intomainfrom Feb 27, 2023
Merged
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
cason
reviewed
Feb 27, 2023
cason
left a comment
There was a problem hiding this comment.
I agree with this approach of separating and starting the RFCs and ADRs from "zero" (i.e., 100).
Two minor points to consider:
- It would be good that the ADR's README pointed to the existing template.
- Figures on the archived ADRs are broken, as they point to files under
./img
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Daniel <daniel.cason@informal.systems>
3 tasks
sergio-mena
pushed a commit
that referenced
this pull request
Jan 11, 2024
sergio-mena
pushed a commit
that referenced
this pull request
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #391.
The same needs to be done for the
v0.37.xbranch.PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments