fix(privval): CV ignore duplicate privval listen when connected (backport #3830)#3897
Merged
mergify[bot] merged 2 commits intov0.37.xfrom Aug 30, 2024
Merged
fix(privval): CV ignore duplicate privval listen when connected (backport #3830)#3897mergify[bot] merged 2 commits intov0.37.xfrom
mergify[bot] merged 2 commits intov0.37.xfrom
Conversation
Resolve #3828 On cometbft startup, duplicate privval request can enter the channel between the time listen begins and a send is attempted. The duplicate listen request will timeout since there is not another signer connecting, filling logs with errors. A duplicate listen request is undesired. --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Daniel <daniel.cason@informal.systems> (cherry picked from commit 5562f11) # Conflicts: # privval/signer_listener_endpoint.go
Contributor
Author
|
Cherry-pick of 5562f11 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
melekes
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #3828
On cometbft startup, duplicate privval request can enter the channel between the time listen begins and a send is attempted.
The duplicate listen request will timeout since there is not another signer connecting, filling logs with errors. A duplicate listen request is undesired.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsThis is an automatic backport of pull request #3830 done by [Mergify](https://mergify.com).