ci: Remove Buf tokens from proto lint workflow#378
Merged
thanethomson merged 2 commits intomainfrom Feb 23, 2023
Merged
Conversation
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
andynog
approved these changes
Feb 23, 2023
Collaborator
andynog
left a comment
There was a problem hiding this comment.
looks good to me, if we get rate limiting issues we can try to put the github token back, but I agree with removing it.
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
* ci: Remove Buf tokens from workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> * Format proto folder readme to trigger workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 126f190) # Conflicts: # proto/README.md
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
* ci: Remove Buf tokens from workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> * Format proto folder readme to trigger workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 126f190)
This was referenced Feb 23, 2023
thanethomson
added a commit
that referenced
this pull request
Feb 23, 2023
* ci: Remove Buf tokens from workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> * Format proto folder readme to trigger workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 126f190) Co-authored-by: Thane Thomson <connect@thanethomson.com>
thanethomson
added a commit
that referenced
this pull request
Feb 23, 2023
* ci: Remove Buf tokens from workflow (#378) * ci: Remove Buf tokens from workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> * Format proto folder readme to trigger workflow Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> (cherry picked from commit 126f190) # Conflicts: # proto/README.md * Fix conflict in proto readme Signed-off-by: Thane Thomson <connect@thanethomson.com> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix the current failing proto lint test in CI.
This was initially only necessary when our repo was private, which is no longer the case.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments