Conversation
* fixing broken link quick-start (#319) * fix link to point to relative page (#319) * fix link to point to rpc page (#319) * fix link that works for rpc (#319) * adding front matter to trigger hooks (#319) * add frontmatter to adr page (#319) * make link to configuration page relative (#319) * remove irrelevant text (#319) * updating relative link and removing irrelevant text (#319) * remove front matter from ADR (#319) * fixing broken links unders docs/tools (#319) * fixing broken links under spec/core (#319) * fixing broken links in spec/abci home (#319) * fix uparrows rendering and broken links (#319) * fixing links, comments on abci methods (#319) * fixing links in tutorials (#319) * adding a landing page for Apps (#319) * renaming qa v0.34 page to show in navigation (#319) * rename title of page for navigation (#319) * fixing links on abci client server (#319) * changes to allow RPC top level navigation on docs site (#319) * fixing some more broken references (#319) * reverting link change as per review (#319) * reverting link change as per review (#319) * reverting link in app-dev as per review (#319) (cherry picked from commit 28baba3) # Conflicts: # docs/core/rpc.md # docs/tools/debugging.md # docs/tutorials/go-built-in.md # docs/tutorials/go.md # spec/abci/README.md # spec/abci/abci++_basic_concepts.md # spec/abci/abci++_client_server.md # spec/abci/abci++_methods.md
Contributor
|
Gave it a stab at fixing the conflicts. e710a9a..dfbfca5 This one was not as easy as the other backport #372. Mainly because of the ABCI++ documentation that was not necessary here, so I deleted it, specifically these files Hope it was the right thing, pls review! |
cason
reviewed
Feb 23, 2023
cason
left a comment
There was a problem hiding this comment.
Some minor adaptations for this branch are needed.
Co-authored-by: Daniel <daniel.cason@informal.systems>
Collaborator
|
@Mergifyio refresh |
Contributor
Author
✅ Pull request refreshed |
andynog
reviewed
Feb 23, 2023
thanethomson
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #368 done by Mergify.
Cherry-pick of 28baba3 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com