Merged
Conversation
3 tasks
andynog
approved these changes
Aug 16, 2024
Collaborator
andynog
left a comment
There was a problem hiding this comment.
changes look good to me, had to fix one unit test that was failing because of a change in the return of PubKey(), other than that lgtm
Collaborator
|
I've reviewed and merged this. Had to fix a couple of tests in the crypto and encoding. @sergio-mena and @melekes please take a look at my commits and see if they made sense. |
aljo242
pushed a commit
that referenced
this pull request
Sep 15, 2025
Part of #3720 `e2e` tests _require_ a method that generates a private key deterministically (from a secret). Without such method, is it not possible for the "tests" step of the `e2e` runner to recreate the node structure as it exists within the runner itself. Manual nightly runs: - [1st try](https://github.com/cometbft/cometbft/actions/runs/10424046666) - [2nd try](https://github.com/cometbft/cometbft/actions/runs/10424939531), after 53321d4 --- - ~[ ] Tests written/updated~ - ~[ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~ - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3720
e2etests require a method that generates a private key deterministically (from a secret). Without such method, is it not possible for the "tests" step of thee2erunner to recreate the node structure as it exists within the runner itself.Manual nightly runs:
PR checklist
[ ] Tests written/updated[ ] Changelog entry added in.changelog(we use unclog to manage our changelog)[ ] Updated relevant documentation (docs/orspec/) and code comments