Merged
Conversation
sergio-mena
approved these changes
Aug 9, 2024
Collaborator
Author
|
@Mergifyio backport v1.x |
Contributor
✅ Backports have been createdDetails
|
4 tasks
melekes
pushed a commit
that referenced
this pull request
Aug 10, 2024
This PR fixes the protos in `v1.x` in order to make the `check proto` test to pass. Same idea as in #3650 but these files were generated in the `v1.x` branch as instead of trying to backport #3650 to `v1.x` since there might be changes to protos in `main` that are not in `v1.x` so this is the best approach to directly update the protos in `v1.x` #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @sergio-mena for figuring it out (#3565 (comment))
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments