fix(privval): re-enable some vote extension-related sanity checks when signing a vote#3649
Merged
sergio-mena merged 7 commits intomainfrom Aug 9, 2024
Merged
Conversation
sergio-mena
commented
Aug 8, 2024
.changelog/unreleased/bug-fixes/3642-re-enable-vote-extension-checks.md
Outdated
Show resolved
Hide resolved
4 tasks
Collaborator
|
@mergify backport v1.x |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 11, 2025
…n signing a vote (#3649) Closes #3642 When vote extensions are disabled, we still need to (sanity-)check that: * Prevotes don't contain an extension signature * `nil` precommits don't contain an extension signature This PR is re-enabling those checks, in alignment with #3565 in `v0.38.x` --- #### PR checklist - ~[ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit a33b8ac) # Conflicts: # .changelog/v1.0.0/bug-fixes/3642-re-enable-vote-extension-checks.md # go.mod # go.sum
2 tasks
mergify bot
added a commit
that referenced
this pull request
Jan 13, 2025
…n signing a vote (backport #3649) (#4789) Closes #3642 When vote extensions are disabled, we still need to (sanity-)check that: * Prevotes don't contain an extension signature * `nil` precommits don't contain an extension signature This PR is re-enabling those checks, in alignment with #3565 in `v0.38.x` --- #### PR checklist - ~[ ] Tests written/updated~ - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - ~[ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3649 done by [Mergify](https://mergify.com). --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3642
When vote extensions are disabled, we still need to (sanity-)check that:
nilprecommits don't contain an extension signatureThis PR is re-enabling those checks, in alignment with #3565 in
v0.38.xPR checklist
[ ] Tests written/updated.changelog(we use unclog to manage our changelog)[ ] Updated relevant documentation (docs/orspec/) and code comments