feat(crypto/bls12381): change to minimal-signature-size#3627
Merged
Conversation
melekes
commented
Aug 5, 2024
|
|
||
| // 4 bytes for field tags + 1 byte for signature LEN + 1 byte for | ||
| // validator address LEN + 1 byte for timestamp LEN. | ||
| maxCommitSigProtoEncOverhead = 4 + 1 + 1 + 1 + 3 // 3 ??? |
Collaborator
Author
There was a problem hiding this comment.
still don't know where 3 bytes are coming from
Collaborator
Author
There was a problem hiding this comment.
message CommitSig {
BlockIDFlag block_id_flag = 1;
bytes validator_address = 2;
google.protobuf.Timestamp timestamp = 3
[(gogoproto.nullable) = false, (gogoproto.stdtime) = true];
bytes signature = 4;
}
There was a problem hiding this comment.
Protobuf overhead?
We really need a way to compute that properly.
Collaborator
Author
There was a problem hiding this comment.
Protobuf overhead?
Yes, but it's unclear from where. varints of 3 fields shouldn't take more than 1 byte because they are all very small.
cason
reviewed
Aug 5, 2024
cason
approved these changes
Aug 6, 2024
cason
left a comment
There was a problem hiding this comment.
Legit.
But we need a better solution for defining the maximum payload size for a block, depending on the signing algorithm adopted.
| // XXX: secp256k1 does not have Size nor MaxSize defined. | ||
| var MaxSignatureSize = cmtmath.MaxInt(ed25519.SignatureSize, cmtmath.MaxInt(bls12381.SignatureLength, 64)) | ||
| // XXX: secp256k1 does not have max signature size defined. | ||
| var MaxSignatureSize = cmtmath.MaxInt( |
There was a problem hiding this comment.
The problem of this approach is that blocks produced using different signing algorithms will have different maximum payload size. We need to re-think this way of computing the maximum payload size, as it depends on the signing algorithm we are using...
mergify bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
Closes #3624 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit 7a5eb45)
4 tasks
melekes
added a commit
that referenced
this pull request
Aug 6, 2024
…) (#3631) Closes #3624 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3627 done by [Mergify](https://mergify.com). Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
itsdevbear
pushed a commit
to itsdevbear/cometbft
that referenced
this pull request
Aug 20, 2024
…tbft#3627)" This reverts commit 7a5eb45.
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
because it's not Ethereum compatible and breaks Berachain Reverts #3627 <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
because it's not Ethereum compatible and breaks Berachain Reverts #3627 <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit e67223f)
3 tasks
melekes
added a commit
that referenced
this pull request
Aug 26, 2024
because it's not Ethereum compatible and breaks Berachain Reverts #3627 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request #3860 done by [Mergify](https://mergify.com). Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
aljo242
pushed a commit
that referenced
this pull request
Sep 4, 2025
Closes #3624 --- - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
aljo242
pushed a commit
that referenced
this pull request
Sep 15, 2025
because it's not Ethereum compatible and breaks Berachain Reverts #3627 <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3624
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments