Conversation
…rovided by a seed node (#3360) Closes #486. Commits: 1. Make `TestConnectionSpeedForPeerReceivedFromSeed` to fail, as it will make the node to connect to more than the configured `MaxNumOutboundPeers` 2. Solve the issue by introducing a channel to wake up `ensurePeersRoutine()`. In this way, the node will not to wait until the next `defaultEnsurePeersPeriod` (30s) before attempting again to connect to new peers (`ensurePeers()` method) whose addresses were provide by the seed node. --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> (cherry picked from commit 4241776) # Conflicts: # .changelog/v0.38.3/bug-fixes/486-p2p-max-outbound.md # p2p/pex/pex_reactor.go # p2p/pex/pex_reactor_test.go
This comment was marked as resolved.
This comment was marked as resolved.
cason
approved these changes
Jul 2, 2024
cason
left a comment
There was a problem hiding this comment.
Diffs match. The only exception is that require.Nil was replaced by require.NoError in this new version. This only affects the test unit changed by this PR, so it should be good.
Collaborator
|
@cason the changelog ended up in the wrong directory here. It should be in |
|
Here: #3457 |
melekes
pushed a commit
that referenced
this pull request
Jul 8, 2024
Fixes issue identified by @sergio-mena: #3396 (comment) --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [ ] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #486.
Commits:
TestConnectionSpeedForPeerReceivedFromSeedto fail, as it will make the node to connect to more than the configuredMaxNumOutboundPeersensurePeersRoutine(). In this way, the node will not to wait until the nextdefaultEnsurePeersPeriod(30s) before attempting again to connect to new peers (ensurePeers()method) whose addresses were provide by the seed node.PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code commentsThis is an automatic backport of pull request #3360 done by [Mergify](https://mergify.com).