test(e2e): reverting PR3211 since it is making e2e nightly to fail#3335
Merged
test(e2e): reverting PR3211 since it is making e2e nightly to fail#3335
Conversation
33 tasks
sergio-mena
approved these changes
Jun 24, 2024
Collaborator
sergio-mena
left a comment
There was a problem hiding this comment.
Checked, via git fiddling, that this is the reverse patch. ✅
Contributor
|
Reading the logs, I think this issue should be easy for us to solve. It seems that the reactor's view of initial height on some nodes is incorrectly being set to 0 (rather than the true initial height). I think theres only two causes for this:
|
|
So lets revert the reversion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #3211 since it is making the e2e nightly to fail in reproducible ways. This PR was identified as the reason for the recent e2e nightly failure on
mainand doing a bi-sect test of all recent commits it was determined that this PR introduced a behavior that makes the tests to fail and indicate a bug or unknown behavior has been introduced.Even though we are reverting this logic for now, we'd be happy to consider it in the future again once more tests are performed and we can ensure it passes all tests.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments