Skip to content

feat(p2p)!: remove PeerReceiveBytesTotal#3298

Merged
melekes merged 6 commits intomainfrom
anton/metrics-2
Jun 19, 2024
Merged

feat(p2p)!: remove PeerReceiveBytesTotal#3298
melekes merged 6 commits intomainfrom
anton/metrics-2

Conversation

@melekes
Copy link
Collaborator

@melekes melekes commented Jun 18, 2024

Follow-up to #3184
Refs #2840


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

melekes added 2 commits June 18, 2024 15:50
MessageReceiveBytesTotal and MessageSendBytesTotal

Follow-up to #3184
Refs #2840
@melekes melekes requested a review from a team as a code owner June 18, 2024 11:56
@melekes melekes requested a review from a team June 18, 2024 11:56
@melekes melekes self-assigned this Jun 18, 2024
@melekes
Copy link
Collaborator Author

melekes commented Jun 18, 2024

cc @ValarDragon

Copy link
Collaborator

@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@melekes melekes added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit a2decd8 Jun 19, 2024
@melekes melekes deleted the anton/metrics-2 branch June 19, 2024 08:43
@melekes melekes added the breaking A breaking change label Jun 19, 2024
@melekes
Copy link
Collaborator Author

melekes commented Jul 10, 2024

@mergify backport v1.x

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2024

backport v1.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jul 10, 2024
Follow-up to #3184
Refs #2840

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

(cherry picked from commit a2decd8)

# Conflicts:
#	.changelog/unreleased/breaking-changes/3184-remove-PeerSendBytesTotal-metric.md
#	docs/explanation/core/metrics.md
#	p2p/metrics.gen.go
#	p2p/metrics.go
melekes added a commit that referenced this pull request Jul 10, 2024
Follow-up to #3184
Refs #2840

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request #3298 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking A breaking change metrics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants