test(e2e): remove flaky logic in test for GetBlockResults#3254
Merged
Conversation
…t and prevent pruning non-determinism
This was referenced Jun 12, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
This pull request resolves the intermittent failures of the gRPC test for GetBlockResults, which were caused by non-deterministic pruning logic. #### PR checklist - [X] Tests written/updated - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec (cherry picked from commit c5dfd20)
4 tasks
andynog
added a commit
that referenced
this pull request
Jun 13, 2024
…3254) (#3259) This pull request resolves the intermittent failures of the gRPC test for GetBlockResults, which were caused by non-deterministic pruning logic. #### PR checklist - [X] Tests written/updated - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3254 done by [Mergify](https://mergify.com). Co-authored-by: Andy Nogueira <me@andynogueira.dev>
hvanz
pushed a commit
that referenced
this pull request
Jun 20, 2024
…3254) (#3259) This pull request resolves the intermittent failures of the gRPC test for GetBlockResults, which were caused by non-deterministic pruning logic. #### PR checklist - [X] Tests written/updated - [ ] ~~Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~~ - [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code comments~~ - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #3254 done by [Mergify](https://mergify.com). Co-authored-by: Andy Nogueira <me@andynogueira.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves the intermittent failures of the gRPC test for GetBlockResults, which were caused by non-deterministic pruning logic.
PR checklist
Changelog entry added in.changelog(we use unclog to manage our changelog)Updated relevant documentation (docs/orspec/) and code comments